False negative with statement ending with parens

[asottile]

if (foo and
    bar()):
    pass

I expect to be rewritten to

if (
    foo and
    bar()
):
    pass

But I imagine the same code that prevents this from being rewritten is firing:

foo('bar {}'.format(
    'baz',
))

which I don't think should be rewritten.

Need to come up with a more clever heuristic here.

[smagafurov]

One more example

bankrupts = [{
    'id': company.bankrupt_id,
    'type': 'company',
} for company in found_companies]

This shouldn't be rewritten with:

bankrupts = [
    {
        'id': company.bankrupt_id,
        'type': 'company',
    } for company in found_companies
]

[asottile]

Should or shouldn't? The second is consistent with the style.

[smagafurov]

The first is also consistent with the style.
And therefore shouldn't be rewritten.

[asottile]

It is not, the style prescribes no hugging braces (unless on a line with only braces)

[smagafurov]

sadly...

[asottile]

No not sadly, that's how this tool is designed. If you don't like that style, don't use the tool! 😆

This issue is about making more constructs get rewritten in that way

[smagafurov]

This tool is very useful
So it is sadly :)

Because I really find this style useful:

async def test_ambiguous(api_request):
    response = await api_request('some_method', some_param='some-value')
    assert response['error'] == {
        'code': 6001,
        'message': 'Validation error',
        'data': {'errors': [
            {'code': 'ambiguous', 'message': 'Ambiguous'},
        ]}
    }

I don't want to expand this line 'data': {'errors': [ because it has no "semantic value".

[asottile]

Tough! The tool can't possibly determine """semantic value"""

I don't know what to tell you

[smagafurov]

oops...

This case works fine for me

async def test_ambiguous(api_request):
    response = await api_request('some_method', some_param='some-value')
    assert response['error'] == {
        'code': 6001,
        'message': 'Validation error',
        'data': {'errors': [
            {'code': 'ambiguous', 'message': 'Ambiguous'},
        ]}
    }

add-trailing-comma doesn't touch it!

Problem is only with this

bankrupts = [{
    'id': company.bankrupt_id,
    'type': 'company',
} for company in found_companies]

[asottile]

Look, I think you're missing the point. The whole goal of the tool is so you don't argue about style.

[smagafurov]

The tool just shouldn't touch this case

bankrupts = [{
    'id': company.bankrupt_id,
    'type': 'company',
} for company in found_companies]

And also shouldn't touch this case too

bankrupts = [
    {
        'id': company.bankrupt_id,
        'type': 'company',
    } for company in found_companies
]

They are both valid

A person can choose according to "semantic value" or some other "magic" he likes

[asottile]

I'm sorry, the first one is ugly and will continue to be rewritten. Please stop

[smagafurov]

PyCharm Reformat Code works exactly that way i want
https://www.jetbrains.com/help/pycharm/reformatting-source-code.html

Please stop

ok

[smagafurov]

Very sorry for my inattention.
I did not notice that you are the author of the tool.
:)
Sorry one more time...
And thank for the tool!