Add the integer multiplication overflow check again & fix make's std output

[bozhodimitrov]

:)

[asottile]

skipping the decode here was ~partially intentional (non-UTF-8 code would crash while producing an error message instead of showing the error message)

[bozhodimitrov]

Yes, but the error output was really unreadable single line -- example:

b"long error message            without new lines and with             white spacing all over the place"

This is why I added the decode - not sure if there is a better way to fix the output.
Maybe trying to decode and if that fails, just use ret.stdout?

[bozhodimitrov]

Maybe like this? Using universal_newlines instead of text for better backwards compatibility (lol) :D

[bozhodimitrov]

BTW😂:

[asottile]

universal_newlines has the same problem as .decode() or encoding=... or text=True in that it hides the actual error on a decoding issue

[asottile]

BTW😂:

I am amazed that works! wow!

[asottile]

I think check=True is actually the easiest patch

[bozhodimitrov]

This is my last bet :) But if you don't like it, I will revert.

[bozhodimitrov]

The CalledProcessError exception also has the same problem with the stdout bytes attribute.

This is the output:

b'cc    -c -o intobject.o intobject.c\nIn file included from allobjects.h:48,\n                 from intobject.c:27:\nmalloc.h:59:13: warning: conflicting types for built-in function \xe2\x80\x98malloc\xe2\x80\x99; expected \xe2\x80\x98void *(long unsigned int)\xe2\x80\x99 [-Wbuiltin-declaration-mismatch]\n   59 | extern ANY *malloc PROTO((unsigned int));\n      |             ^~~~~~\nmalloc.h:1:1: note: \xe2\x80\x98malloc\xe2\x80\x99 is declared in header \xe2\x80\x98<stdlib.h>\xe2\x80\x99\n  +++ |+#include <stdlib.h>\n    1 | /***********************************************************\nmalloc.h:60:13: warning: conflicting types for built-in function \xe2\x80\x98calloc\xe2\x80\x99; expected \xe2\x80\x98void *(long unsigned int,  long unsigned int)\xe2\x80\x99 [-Wbuiltin-declaration-mismatch]\n   60 | extern ANY *calloc PROTO((unsigned int, unsigned int));\n      |             ^~~~~~\nmalloc.h:60:13: note: \xe2\x80\x98calloc\xe2\x80\x99 is declared in header \xe2\x80\x98<stdlib.h>\xe2\x80\x99\nmalloc.h:61:13: warning: conflicting types for built-in function \xe2\x80\x98realloc\xe2\x80\x99; expected \xe2\x80\x98void *(void *, long unsigned int)\xe2\x80\x99 [-Wbuiltin-declaration-mismatch]\n   61 | extern ANY *realloc PROTO((ANY *, unsigned int));\n      |             ^~~~~~~\nmalloc.h:61:13: note: \xe2\x80\x98realloc\xe2\x80\x99 is declared in header \xe2\x80\x98<stdlib.h>\xe2\x80\x99\nmalloc.h:62:13: warning: conflicting types for built-in function \xe2\x80\x98free\xe2\x80\x99; expected \xe2\x80\x98void(void *)\xe2\x80\x99 [-Wbuiltin-declaration-mismatch]\n   62 | extern void free PROTO((ANY *)); /* XXX sometimes int on Unix old systems */\n      |             ^~~~\nmalloc.h:62:13: note: \xe2\x80\x98free\xe2\x80\x99 is declared in header \xe2\x80\x98<stdlib.h>\xe2\x80\x99\nintobject.c: In function \xe2\x80\x98int_mul\xe2\x80\x99:\nintobject.c:198:8: error: lvalue required as decrement operand\n  198 |        ---x = a * b;\n      |        ^~\nmake: *** [<builtin>: intobject.o] Error 1\n'