Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babi should always open files using UTF-8 #78

Closed
asottile opened this issue Jul 3, 2020 · 1 comment · Fixed by #94
Closed

babi should always open files using UTF-8 #78

asottile opened this issue Jul 3, 2020 · 1 comment · Fixed by #94
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@asottile
Copy link
Owner

asottile commented Jul 3, 2020

especially on windows, this can result in mojibake

ensure that the open calls go through encoding='UTF-8' -- maybe also validate stdin does the same
@asottile asottile added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 3, 2020
@brynphillips
Copy link
Contributor

I'll take a look at tomorrow if you don't mind. 😄

@7brokenmirrors 7brokenmirrors mentioned this issue Aug 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add checks for UTF-8
2 participants
@asottile @brynphillips