You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#17 allowed typing.NoReturn instead of NoReturn, but we do import typing as t for a shorter name.
I know this is similar to the typing.overload issue in PyCQA/pyflakes#561. Alternatively, maybe this can be addressed with a config option like typing_namespace = t to change what name the plugin looks for.
I was trying to run this on our projects as someone brought up an issue with the import in 3.6.0, but was surprised to see no errors reported. Not a huge deal, I can just reference the supported list in your code and do it manually for now.
The text was updated successfully, but these errors were encountered:
I'd rather not, the prevailing convention is to import from typing -- aliasing is a slipperly slope down trying to solve the halting problem (what about import typing; x = typing? what if that's conditional?) -- it's basically intractable
I'd recommend not going against the grain and importing from typing ... directly
#17 allowed
typing.NoReturn
instead ofNoReturn
, but we doimport typing as t
for a shorter name.I know this is similar to the
typing.overload
issue in PyCQA/pyflakes#561. Alternatively, maybe this can be addressed with a config option liketyping_namespace = t
to change what name the plugin looks for.I was trying to run this on our projects as someone brought up an issue with the import in 3.6.0, but was surprised to see no errors reported. Not a huge deal, I can just reference the supported list in your code and do it manually for now.
The text was updated successfully, but these errors were encountered: