Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify library never returns "or later" for license #137

Closed
garthwilliamson opened this issue May 9, 2022 · 5 comments
Closed

Identify library never returns "or later" for license #137

garthwilliamson opened this issue May 9, 2022 · 5 comments

Comments

@garthwilliamson
Copy link

Ideally the reformat would leave -or-later on the end if it is "correct" otherwise. An alternative might be to add a new option to disable the license checks.

@asottile
Copy link
Owner

asottile commented May 9, 2022

the license field is meant to be a SPDX identifier, "-or-later" is not a valid identifier

@asottile asottile closed this as completed May 9, 2022
@garthwilliamson
Copy link
Author

According to https://spdx.org/licenses/, there are many identifiers with the suffix, for example GPL-2.0-or-later. Because the LICENSE file is the same whether it's straight GPL or GPL-2.0-or-later, identify can't tell the difference.

@asottile
Copy link
Owner

ah right GPL cancer

surely if the licenses are byte identical then then or-later is redundant right?

@garthwilliamson
Copy link
Author

I don't know - pypi doesn't seem to have very strict rules about getting these things exactly right, so it might not make any material difference.

If it bothers us enough, which pull request would you prefer? Option to avoid licence changes altogether, or to keep or-later when it already exists and GPL is in the string?

@asottile
Copy link
Owner

does your license contain an "or later" clause in its contents? if not -or-later is probably not correct. (though identify doesn't detect the or later clause as it is).

setup-cfg-fmt intentionally doesn't have options so definitely not that.

I suspect the actual fix is having identify identify the or later clause

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants