Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip extensions for smaller modules #90

Closed
corka149 opened this issue Aug 18, 2021 · 2 comments · Fixed by #94
Closed

strip extensions for smaller modules #90

corka149 opened this issue Aug 18, 2021 · 2 comments · Fixed by #94

Comments

@corka149
Copy link
Contributor

The modules created with Go can be big. go build offers the possibility to reduce size by omitting debugging information and symbols. I found out in a test that this could reduce the size of a wheel by 42 %.

My suggestion would be to add 'strip': False to build_golang as a switch. This would add '-ldflags=-s -w' to go build or not.

@asottile
Copy link
Owner

is there a reason to not do this unconditionally? I generally prefer fewer options unless someone has an explicit usecase for toggling a value

@corka149
Copy link
Contributor Author

Sounds reasonable. I changed it so that True is the default value for stripping. It might become handy in case of bugs. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants