Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: configure does not support type-only typescript imports #404

Closed
jbedard opened this issue Mar 15, 2023 · 1 comment
Closed

[Bug]: configure does not support type-only typescript imports #404

jbedard opened this issue Mar 15, 2023 · 1 comment
Assignees
@jbedard
Labels
bug Something isn't working
Milestone
Gazelle Usability...

Comments

@jbedard
Copy link
Member

jbedard commented Mar 15, 2023 •
edited

What happened?

Import statements should produce the correct ts_project(deps) when bazel configure runs. Today type-only imports are lost and not picked up by configure.

Version

Aspect CLI version: 5.2.1

How to reproduce

No response

Any other information?

No response
@jbedard jbedard added the bug Something isn't working label Mar 15, 2023
@jbedard jbedard self-assigned this Mar 15, 2023
@github-actions github-actions bot added the untriaged Requires traige label Mar 15, 2023
@jbedard jbedard removed the untriaged Requires traige label Mar 17, 2023
@jbedard jbedard mentioned this issue Apr 4, 2023
Closed
@jbedard
Copy link
Member Author

jbedard commented Jun 12, 2023

This has been fixed by switching to treesitter for parsing + querying the ts ast.

@jbedard jbedard closed this as completed Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbedard jbedard

Labels
bug Something isn't working
Projects
Open Source
Archived in project
Milestone
Gazelle Usability & Documentation
Development

No branches or pull requests
1 participant
@jbedard