Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_binary is missing features from js_run_binary #575

Open
alexeagle opened this issue Oct 4, 2023 · 0 comments
Open

run_binary is missing features from js_run_binary #575

alexeagle opened this issue Oct 4, 2023 · 0 comments
Labels
enhancement New feature or request funding needed Contribute to https://opencollective.com/aspect-build

Comments

@alexeagle
Copy link
Member

What happened?

run_binary doesn't have any wrapper program, so it can't do these things:

  • capture stdout/stderr/exit code as "outputs"
  • chdir to a specific working directory
  • throw away logspam on success

Now that we have a good pattern for shipping binaries written in Go, we could have a wrapper program for all run_binary calls to provide these features, similar to how we added stamping ability to expand_template.

Version

HEAD

How to reproduce

No response

Any other information?

No response

@alexeagle alexeagle added the bug Something isn't working label Oct 4, 2023
@alexeagle alexeagle added this to the 2.0 milestone Oct 4, 2023
@github-actions github-actions bot added the untriaged Requires traige label Oct 4, 2023
@alexeagle alexeagle added enhancement New feature or request funding needed Contribute to https://opencollective.com/aspect-build and removed bug Something isn't working untriaged Requires traige labels Oct 5, 2023
@alexeagle alexeagle removed this from the 2.0 milestone Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request funding needed Contribute to https://opencollective.com/aspect-build
Projects
Status: No status
Development

No branches or pull requests

1 participant