[FR]: Add clang-tidy

[alexeagle]

What is the current behavior?

No response

Describe the feature

Followup to #101 suggested by @jsharpe

[HarveyJMartin]

Hi, has there been any progress on the addition of this ?

[jsharpe]

I don't think anyone is actively working on this at the moment but checkout https://github.com/erenon/bazel_clang_tidy for something that might meet your needs / the basis for a contribution into this ruleset.

[peakschris]

@alexeagle do you have any guidance as to how this should be done? Should rules_lint reference bazel_clang_tidy, or should the aspect from bazel_clang_tidy be copied and pasted into rules_lint? (i note kind offer from bazel_clang_tidy owner, and also that bazel_clang_tidy seems to be under active development by the community)

Do you think clang-tidy fixes should be integrated similar to eslint with the patch files output and used for fixes?

[alexeagle]

Right, I forgot about erenon/bazel_clang_tidy#35

I imagine that bazel_clang_tidy would be replaced by clang_tidy in rules_lint, so I wouldn't want to add a dependency from this repo to that one. Instead I'd suggest using their implementation as a reference, maybe some copy-paste code but only with understanding it.

Yes, fixes should be applied the same way we do for ruff and eslint already, just by running clang-tidy in its fix mode, and the resulting patch produced as an action by rules_lint.