Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: 0.14 release broke formatter accepting file arguments #169

Closed
alexeagle opened this issue Mar 13, 2024 · 3 comments
Closed

[Bug]: 0.14 release broke formatter accepting file arguments #169

alexeagle opened this issue Mar 13, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@alexeagle
Copy link
Member

alexeagle commented Mar 13, 2024

What happened?

Due to keith/rules_multirun#44
(and obviously missing integration testing in this repo)

Version

0.14.0 and 0.14.1

How to reproduce

INFO: Running command line: bazel-bin/tools/format/format.bash lint.sh
Traceback (most recent call last):
  File "/private/var/tmp/_bazel_alexeagle/3eecd93732ac7c6f4f360a54a468da50/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/tools/format/format.bash.runfiles/_main/../rules_multirun~0.7.0/internal/multirun.py", line 91, in <module>
    _main(sys.argv[-1])
  File "/private/var/tmp/_bazel_alexeagle/3eecd93732ac7c6f4f360a54a468da50/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/tools/format/format.bash.runfiles/_main/../rules_multirun~0.7.0/internal/multirun.py", line 73, in _main
    with open(path) as f:
FileNotFoundError: [Errno 2] No such file or directory: 'lint.sh'
@alexeagle alexeagle added the bug Something isn't working label Mar 13, 2024
@alexeagle
Copy link
Member Author

The bug is fixed by a rollback, leaving this open for the roll-forward

@hunshcn
Copy link
Contributor

hunshcn commented Mar 22, 2024

The bug is fixed by a rollback, leaving this open for the roll-forward

it is time

@alexeagle
Copy link
Member Author

Thanks @hunshcn , rolled forward in #182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants