Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chkstow incorrectly assumes /usr/local exists #72

Open
wdkrnls opened this issue Jun 18, 2020 · 3 comments
Open

chkstow incorrectly assumes /usr/local exists #72

wdkrnls opened this issue Jun 18, 2020 · 3 comments

Comments

@wdkrnls
Copy link

wdkrnls commented Jun 18, 2020

I'm running Stow on Guix where /usr/local does not exist by default. Considering that Stow is now frequently used for managing .dotfiles, would it make sense to make the default target directory the users home directory instead? That will probably always exist no matter the distribution. Alternatively, does a default target directory need to be set at all?

@FichteFoll
Copy link

FichteFoll commented Jun 19, 2020

What does 'default target directory' mean here? The default is "the parent of the stow directory", where the stow directory is the current working directory (don't think this can be changed). If you just mean for the documentation, then I don't think this is warranted, as the example usage of /usr/local is clearly explained in that, imo.

Regardless, changing the default target directory would be a huge breaking change. Even requiring a target directory to be specified would be a breaking change. (Not as huge because it could still notify and the user about the missing parameter instead of doing something unexpected, but still unacceptable in my opinion.)

@FichteFoll
Copy link

FichteFoll commented Jun 19, 2020

Oh, I just now after posting realized this is talking about chkstow. That should mirror stow's logic for determining the stow directory, imo. Probably consider .stowrc also.

@wdkrnls
Copy link
Author

wdkrnls commented Jun 19, 2020

Yes, I am referring to the $ENV[STOW_DIR] || '/usr/local' logic at the top of (only) the chkstow utility source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants