-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port the social providers to the new ASP.NET Core 2.0 authentication stack #170
Comments
Will a final |
@martincostello not sure. The OpenID generic provider - that shares the same versioning as this repository - relies on AngleSharp, that doesn't yet offer a 1.0.0 version 😢 |
I wanna to know where should I start the jobs? Is it okay to start working on the |
Also wondering about this as I need a Strava login for asp.net core 2.0 |
I need vkontakte authentication for asp.net core 2.0. Can I help you? |
I'm starting working on it, would you like to create a new branch such as BTW, I'll pay attention to the problems you pointed at aspnet-contrib/AspNet.Security.OpenId.Providers#35. |
Hello, everyone.Can I know when you to porting to asp.net core 2.0 VK provider? |
Hey all, I ported the Spotify provider service to the ASP.NET Core 2.0 stack. It's modeled after Microsoft's own implementations of their Facebook and MicrosoftAccount authorizations. The problem is that it's a homeless amalgam, and I don't know where to put it. It uses Microsoft's namespaces and dependencies, and thus requires nothing from the other parts of this project, although that could obviously be changed in a future patch. Is there a 2.0 branch in the works for this project, or otherwise some place that I can push this? Would be a shame to keep it to myself. |
@0xNF that's why I ask for a new branch. |
Please update us on Asp.net Core 2 Support. |
I created a new If you want to help migrate the other providers, please use it as a starting point so we keep everything consistent. Feel free to include multiple providers in a single PR but please push separate commits using the |
I've already ported the Amazon provider in the repo where I originally wrote that code, so will port that over sometime this week. |
I'm going to start migrating Vkontakte and yet unreleased Odnoklassniki (#163) providers. BTW, @PinpointTownes, how should I deal with the latter? Should I merge the original branch or just start over by adding ported code? And the last but not least. Most of us require real-life live testing/using new already ported providers. Would you be so kind to reveal this project's AppVeyor NuGet feed URL and/or build configuration? This will help in testing builds even before opening pull requests. |
PR to update the Amazon provider in #179. |
Hello @PinpointTownes, how's it going? |
@PinpointTownes can you provide any ETA? |
I reviewed all the submitted PRs and asked the contributions to include a few changes. @kinosang's PR is almost ready and will be merged ASAP. |
Migrated the LinkedIn provider in PR #183, please review. |
VK auth is available in https://github.com/mkhrapunov/AspNet.Security.OAuth.VK |
I'll start working on other providers after get my computer repaired. |
@mkhrapunov where were you before =) I just finished my version, spent a lot of time =) |
OK and VK providers (for both 1.0 and 2.0) are finally available: https://github.com/Digillect/AspNetCoreOAuthProviders. As well as in NuGet. |
FYI: of the 47 providers, 22 have already been ported to 2.0 and there's a PR for a 23rd one (Vkontakte). The updated list can be found here: #182 (comment). |
https://twitter.com/PinpointTownes/status/935240112954400769 |
@PinpointTownes Should the readme be updated to mention Core 2.0, or are you waiting until you move the packages out of RC status? |
No description provided.
The text was updated successfully, but these errors were encountered: