Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the social providers to the new ASP.NET Core 2.0 authentication stack #170

Closed
kevinchalet opened this issue Aug 14, 2017 · 27 comments
Closed

Comments

@kevinchalet
Copy link
Member

No description provided.

@kevinchalet kevinchalet added this to the 2.0.0-preview1 milestone Aug 14, 2017
@martincostello
Copy link
Member

Will a final 1.0.0 be published to NuGet before this?

@kevinchalet
Copy link
Member Author

@martincostello not sure. The OpenID generic provider - that shares the same versioning as this repository - relies on AngleSharp, that doesn't yet offer a 1.0.0 version 😢

@kinosang
Copy link
Contributor

kinosang commented Sep 1, 2017

I wanna to know where should I start the jobs? Is it okay to start working on the dev branch? or should we start a new branch for it?

@runxc1
Copy link

runxc1 commented Sep 4, 2017

Also wondering about this as I need a Strava login for asp.net core 2.0

@ntemirov
Copy link

ntemirov commented Sep 5, 2017

I need vkontakte authentication for asp.net core 2.0. Can I help you?

@kinosang
Copy link
Contributor

kinosang commented Sep 11, 2017

I'm starting working on it, would you like to create a new branch such as 2.0 because I can't port all those providers at once.

BTW, I'll pay attention to the problems you pointed at aspnet-contrib/AspNet.Security.OpenId.Providers#35.

@sergeushenecz
Copy link

Hello, everyone.Can I know when you to porting to asp.net core 2.0 VK provider?

@0xNF
Copy link

0xNF commented Sep 20, 2017

Hey all, I ported the Spotify provider service to the ASP.NET Core 2.0 stack. It's modeled after Microsoft's own implementations of their Facebook and MicrosoftAccount authorizations.

The problem is that it's a homeless amalgam, and I don't know where to put it. It uses Microsoft's namespaces and dependencies, and thus requires nothing from the other parts of this project, although that could obviously be changed in a future patch.

Is there a 2.0 branch in the works for this project, or otherwise some place that I can push this? Would be a shame to keep it to myself.

@kinosang
Copy link
Contributor

@0xNF that's why I ask for a new branch.

@vishalmgiri
Copy link

Please update us on Asp.net Core 2 Support.
I am also willing to support it.

@kevinchalet
Copy link
Member Author

I created a new experimental branch and ported the GitHub provider to ASP.NET Core 2.0.

If you want to help migrate the other providers, please use it as a starting point so we keep everything consistent.

Feel free to include multiple providers in a single PR but please push separate commits using the Migrate the XYZ provider to ASP.NET Core 2.0 message pattern.

@kinosang
Copy link
Contributor

kinosang commented Sep 20, 2017

#173 for:

  • ArcGIS
  • Asana
  • Autodesk
  • BattleNet
  • Discord
  • Dropbox
  • Imgur
  • Paypal
  • Reddit
  • Twitch
  • Vimeo
  • Weibo
  • Weixin
  • WordPress
  • Yahoo
  • Yandex

Help wanted:

  • Yahoo (don't know which is the best way to extract claims from the response)
  • Imgur (the same problem as Yahoo)

@martincostello
Copy link
Member

I've already ported the Amazon provider in the repo where I originally wrote that code, so will port that over sometime this week.

@Vertigo093i
Copy link

I'm going to start migrating Vkontakte and yet unreleased Odnoklassniki (#163) providers.

BTW, @PinpointTownes, how should I deal with the latter? Should I merge the original branch or just start over by adding ported code?

And the last but not least. Most of us require real-life live testing/using new already ported providers. Would you be so kind to reveal this project's AppVeyor NuGet feed URL and/or build configuration? This will help in testing builds even before opening pull requests.

@Moza805
Copy link

Moza805 commented Sep 20, 2017

Just PR'd an updated Strava authenticator into experimental branch #177 . Heads up to @runxc1 in case you want to check it out

@martincostello
Copy link
Member

PR to update the Amazon provider in #179.

@kinosang
Copy link
Contributor

Hello @PinpointTownes, how's it going?

@agoretsky
Copy link

@PinpointTownes can you provide any ETA?

@kevinchalet
Copy link
Member Author

@PinpointTownes can you provide any ETA?

I reviewed all the submitted PRs and asked the contributions to include a few changes. @kinosang's PR is almost ready and will be merged ASAP.

@AlvinStanescu
Copy link

Migrated the LinkedIn provider in PR #183, please review.

@mkhrapunov
Copy link

VK auth is available in https://github.com/mkhrapunov/AspNet.Security.OAuth.VK

@kinosang
Copy link
Contributor

kinosang commented Oct 30, 2017

I'll start working on other providers after get my computer repaired.

@chi-up
Copy link

chi-up commented Oct 31, 2017

@mkhrapunov where were you before =) I just finished my version, spent a lot of time =)

@Vertigo093i
Copy link

OK and VK providers (for both 1.0 and 2.0) are finally available: https://github.com/Digillect/AspNetCoreOAuthProviders. As well as in NuGet.

@kevinchalet
Copy link
Member Author

FYI: of the 47 providers, 22 have already been ported to 2.0 and there's a PR for a 23rd one (Vkontakte).

The updated list can be found here: #182 (comment).

@kevinchalet
Copy link
Member Author

Great news: the 46 aspnet-contrib OAuth2 social providers have been migrated to #aspnetcore 2.0. Special thanks to everyone who helped and kudos to Chino Chang who ported 37 providers! The packages can be downloaded from our #myget feed: https://www.myget.org/F/aspnet-contrib/api/v3/index.json

https://twitter.com/PinpointTownes/status/935240112954400769

@MV10
Copy link

MV10 commented Jan 24, 2018

@PinpointTownes Should the readme be updated to mention Core 2.0, or are you waiting until you move the packages out of RC status?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests