Skip to content
This repository has been archived by the owner on Dec 24, 2020. It is now read-only.

Make ID Token signature mandatory #548

Closed
danieljee opened this issue Aug 30, 2019 · 2 comments
Closed

Make ID Token signature mandatory #548

danieljee opened this issue Aug 30, 2019 · 2 comments

Comments

@danieljee
Copy link

In https://openid.net/specs/openid-connect-core-1_0.html#IDToken it says:

ID Tokens MUST be signed using JWS [JWS] and optionally both signed and then encrypted using JWS [JWS] and JWE [JWE] respectively

In SerializeIdentityTokenAsync method of OpenIdConnectServerHandler, the signing is optional for authorization code grant. I thought it was only the signature validation by the client that is optional.

@kevinchalet
Copy link
Member

Yep, you're right. But that's kinda a degraded a mode, that allows using ASOS and the basic code code flow without having to register signing credentials, that won't be used by the client application to validate the identity token anyway.

It won't be a thing in OpenIddict 3.0, where you'll have to register an asymmetric signing key (with a check made at startup).

@danieljee
Copy link
Author

Okay thanks for the explanation

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants