Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change to FileSystemGlobbing package in beta8 #58

Open
analogrelay opened this issue Aug 28, 2015 · 0 comments
Open

Breaking change to FileSystemGlobbing package in beta8 #58

analogrelay opened this issue Aug 28, 2015 · 0 comments

Comments

@analogrelay
Copy link

In order to add support for extracting the "stem" of a globbing match (see aspnet/FileSystem#120), a breaking change was added to the FileSystemGlobbing package (Microsoft.Framework.FileSystemGlobbing). Previously, the result of running Matcher.Execute was a list of strings. Now, it is a list of FilePatternMatch objects which contain both the full path to the match in the Path property and the "stem" (or the part matched by the globs) of the match in the Stem property.

As a result, any consumers of this code will need to update to adjust for this change in method signature. In almost all cases, it should just be a matter of changing types and appending .Path calls. See aspnet/Mvc#3052 for a sample change reacting to this one.

In accordance with the discussion in #47 - this post has been locked to avoid flooding watchers of this repo. See the corresponding issue aspnet/FileSystem#121 for feedback and discussion.

@analogrelay analogrelay added this to the 1.0.0-beta8 milestone Aug 28, 2015
@aspnet aspnet locked and limited conversation to collaborators Aug 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant