Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TagHelpers understand enum typed attributes better. #96

Open
NTaylorMullen opened this issue Oct 29, 2015 · 1 comment
Open

TagHelpers understand enum typed attributes better. #96

NTaylorMullen opened this issue Oct 29, 2015 · 1 comment

Comments

@NTaylorMullen
Copy link
Member

TagHelpers now better understand enum values. This will break pre-existing MVC applications that have TagHelpers who have enum based attributes.

A great example of this is the validation summary TagHelper added by Microsoft.AspNet.Mvc.TagHelpers. Examples using this TagHelper are below.

Before

<div asp-validation-summary="ValidationSummary.All">...</div>

@{
    var valSummary = ValidationSummary.ModelOnly;
}
<div asp-validation-summary="valSummary">...</div>

After

<div asp-validation-summary="All">...</div>

@{
    var valSummary = ValidationSummary.ModelOnly;
}
<div asp-validation-summary="@valSummary">...</div>

Here is the issue that tracked the work.

@NTaylorMullen NTaylorMullen added this to the 1.0.0-rc1 milestone Oct 29, 2015
@aspnet aspnet locked and limited conversation to collaborators Oct 29, 2015
@NTaylorMullen
Copy link
Member Author

For discussion and feedback, please see the related discussion issue here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant