Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mvc/razor-pages fix UseInMemoryDatabase #4544

Closed
Rick-Anderson opened this issue Oct 12, 2017 · 4 comments
Closed

mvc/razor-pages fix UseInMemoryDatabase #4544

Rick-Anderson opened this issue Oct 12, 2017 · 4 comments
Assignees
@Rick-Anderson
Labels
Good first issue Good for newcomers. Help wanted Up for grabs. We would accept a PR to help resolve this issue Pri0 Urgent priority
Milestone
Backlog

Comments

@Rick-Anderson
Copy link
Contributor

UseInMemoryDatabase API has changed (remove name)
@Rick-Anderson Rick-Anderson added bug Good first issue Good for newcomers. Pri0 Urgent priority Help wanted Up for grabs. We would accept a PR to help resolve this issue labels Oct 12, 2017
@Rick-Anderson Rick-Anderson self-assigned this Oct 12, 2017
@isaacrlevin
Copy link
Contributor

@Rick-Anderson looks like you still need to pass string into the extension per master on GitHub

image

@isaacrlevin
Copy link
Contributor

@Rick-Anderson @scottaddie please above is correct

@guardrex
Copy link
Collaborator

guardrex commented Nov 9, 2017

@isaac2004 That's correct. I ran into this with a few sample upgrades to 2.0. I've been using "InMemoryDb" as the name. Do we want to be consistent about that?

@Rick-Anderson
Copy link
Contributor Author

Looks like all the samples in aspnetcore\mvc\razor-pages\index\sample pass a string param - so I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rick-Anderson Rick-Anderson

Labels
Good first issue Good for newcomers. Help wanted Up for grabs. We would accept a PR to help resolve this issue Pri0 Urgent priority
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@guardrex @Rick-Anderson @isaacrlevin