New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calling Request.EnableRewind throw on 3.0.0-preview7 #12505
Comments
@davidfowl is this a scenario we still try to support where we have different dependencies to ASP.NET Core? |
/cc @Tratcher. Does this need a breaking change announcement? |
This is part of the pubternal move to internal. We haven’t written the uber announcement for that as yet. |
@WellspringCS That's related only in that there's a dependency mismatch. |
OK, so likely to go away when they release an updated version, I take it. |
Closing as this should be fixed when referencing the latest versions. |
This problem persists after version |
@sc1994 if I read this correctly you would need to change any calls to EnableRewind to EnableBuffering as shown in the the pull request that sentry committed to fix this in their code. getsentry/sentry-dotnet@520bb78 |
An ASP.NET Core 3 app calling out to a library which depends on
Microsoft.AspNetCore.Hosting 2.x
and accessHttpContext.Request.EnableRewind()
throws an exception.To Reproduce
I have a repro here: https://github.com/bruno-garcia/aspnetcore3-hosting2.x-enable-rewind-throws
Steps to reproduce the behavior:
3.0.100-preview7-012821
.netstandard2.0
Microsoft.AspNetCore.Hosting
version 2.2HttpContext.Request.EnableRewind()
in it.Expected behavior
Request buffering happens
Error:
Raised here: getsentry/sentry-dotnet#249
In all fairness the extension method in question is under
Microsoft.AspNetCore.Http.Internal
and even on2.1
it was also availableEnableBuffering
. I've replaced the two in the library and it's working properly.The text was updated successfully, but these errors were encountered: