Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blazor] ResolveBlazorRuntimeDependencies fails when project references contain satellite assemblies #17644

Closed
pranavkm opened this issue Dec 6, 2019 · 1 comment
Assignees
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly
Projects

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Dec 6, 2019

ResolveBlazorRuntimeDependencies expects to only ever see unique assembly names. However, the list that _ResolveBlazorRuntimeDependencies passes it includes satellite assemblies which results in it failing. We want satellite assemblies to be copied over to the build output (I think), but they need to be ignored for purposes of resolving runtime dependencies.

@pranavkm pranavkm added area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly labels Dec 6, 2019
@mkArtakMSFT mkArtakMSFT added this to the blazor-wasm-preview5 milestone Dec 6, 2019
@mkArtakMSFT mkArtakMSFT added the bug This issue describes a behavior which is not expected - a bug. label Dec 6, 2019
@pranavkm
Copy link
Contributor Author

pranavkm commented Dec 9, 2019

Workarounds for this include:

  • Turn on the linker by setting <BlazorLinkOnBuild>true</BlazorLinkOnBuild>
  • If linking cannot be enabled, add the following target to the project file
<Target Name="_RemoveSatelliteAssemblies" BeforeTargets="_ResolveBlazorRuntimeDependencies">
  <ItemGroup>
    <_BlazorDependencyInput Remove="@(_BlazorDependencyInput->WithMetadataValue('AssetType', 'resources'))"  />
  </ItemGroup>
</Target>

pranavkm added a commit that referenced this issue Jan 8, 2020
* Pass the same closure of assemblies that is used by the SDK's linker to Blazor's linker and ResolveBlazorRuntimeDependencies task
* Quote the mono linker path

Fixes #17644
Fixes #17754
@mkArtakMSFT mkArtakMSFT added this to In Progress (CC: 21st Jan) in Blazor WASM Jan 10, 2020
pranavkm added a commit that referenced this issue Jan 10, 2020
* Pass the same closure of assemblies that is used by the SDK's linker to Blazor's linker and ResolveBlazorRuntimeDependencies task
* Quote the mono linker path

Fixes #17644
Fixes #17754
pranavkm added a commit that referenced this issue Jan 15, 2020
* Handle satellite assemblies in the Blazor build targets

* Pass the same closure of assemblies that is used by the SDK's linker to Blazor's linker and ResolveBlazorRuntimeDependencies task
* Quote the mono linker path

Fixes #17644
Fixes #17754
@pranavkm pranavkm added Done This issue has been fixed and removed Working labels Jan 15, 2020
Blazor WASM automation moved this from In Progress (CC: 21st Jan) to Done Jan 15, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly
Projects
No open projects
Blazor WASM
  
Done
Development

No branches or pull requests

2 participants