Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP/2 pseudo-headers as known headers #4761

Closed
Tratcher opened this issue Jan 19, 2018 · 0 comments · Fixed by #19457
Closed

Add HTTP/2 pseudo-headers as known headers #4761

Tratcher opened this issue Jan 19, 2018 · 0 comments · Fixed by #19457
Assignees
@JamesNK
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-kestrel HTTP2 Perf
Milestone
5.0.0-preview2

Comments

@Tratcher
Copy link
Member

https://github.com/aspnet/KestrelHttpServer/blob/526dfdb332b30fd6042d8ef8d1a2ba99cc654010/src/Kestrel.Core/Internal/Http2/Http2Stream.cs#L55-L66

It looks like these are being treated as unknown headers. Consider adding them to KnownHeaders. Note we'll have to special case them in the generator as the colon does not translate into a valid C# member name.

https://github.com/aspnet/KestrelHttpServer/blob/526dfdb332b30fd6042d8ef8d1a2ba99cc654010/tools/CodeGenerator/KnownHeaders.cs
@muratg muratg changed the title Add Http/2 psudo-headers as known headers Add Http/2 pseudo-headers as known headers Sep 19, 2018
@muratg muratg changed the title Add Http/2 pseudo-headers as known headers Add HTTP/2 pseudo-headers as known headers Sep 19, 2018
@aspnet-hello aspnet-hello transferred this issue from aspnet/KestrelHttpServer Dec 13, 2018
@aspnet-hello aspnet-hello added this to the 3.1.0 milestone Dec 13, 2018
@analogrelay analogrelay modified the milestones: 3.1.0, 3.0.0-preview8 Jun 4, 2019
@analogrelay analogrelay modified the milestones: 3.0.0-preview8, Backlog Jul 9, 2019
@analogrelay analogrelay modified the milestones: 3.0.0-preview8, Backlog Jul 9, 2019
@shirhatti shirhatti modified the milestones: Backlog, 5.0.0-preview1 Sep 5, 2019
@JamesNK JamesNK mentioned this issue Sep 5, 2019
Closed
7 tasks
@Tratcher Tratcher mentioned this issue Sep 26, 2019
Closed
@JamesNK JamesNK mentioned this issue Feb 28, 2020
Merged
@JamesNK JamesNK self-assigned this Feb 28, 2020
@JamesNK JamesNK mentioned this issue Feb 28, 2020
Merged
@dotnet dotnet locked as resolved and limited conversation to collaborators Mar 30, 2020
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JamesNK JamesNK

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-kestrel HTTP2 Perf
Projects
None yet
Milestone
5.0.0-preview2
Development

Successfully merging a pull request may close this issue.

Add HTTP/2 pseudo headers as known headers dotnet/aspnetcore
7 participants
@analogrelay @halter73 @JamesNK @Tratcher @shirhatti @amcasey @aspnet-hello