Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C# 8 Readiness #5092

Closed
rynowak opened this issue Sep 14, 2018 · 8 comments
Closed

C# 8 Readiness #5092

rynowak opened this issue Sep 14, 2018 · 8 comments
Assignees
@NTaylorMullen
Labels
area-blazor Includes: Blazor, Razor Components Components Big Rock This issue tracks a big effort which can span multiple issues cost: L Will take from 5 - 10 days to complete Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-razor-pages
Milestone
3.0.0-preview4

Comments

@rynowak
Copy link
Member

rynowak commented Sep 14, 2018

We need to evaluate and update Razor for C# 8. This will align with 3.0

https://github.com/dotnet/csharplang/milestone/8
https://channel9.msdn.com/Events/dotnetConf/2018/S103
@mkArtakMSFT
Copy link
Member

Thanks @rynowak.

@rynowak
Copy link
Member Author

rynowak commented Sep 20, 2018

Additional note: dotnet/csharplang#1630 (comment)

@NTaylorMullen
Copy link
Contributor

Additional note: Need to handle the nonnulltypes feature when things are turned on at the compiler level. In generated code we set bits to null in several locations without being explicit on the types.

Reacting to this could be as simple as adding pragma warnings or changing how certain assignments generate.

@aspnet-hello aspnet-hello transferred this issue from aspnet/Razor Dec 14, 2018
@aspnet-hello aspnet-hello added this to the 3.0.0 milestone Dec 14, 2018
@aspnet-hello aspnet-hello added 1 - Ready area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-razor-pages labels Dec 14, 2018
@danroth27 danroth27 added this to To do in Blazor via automation Jan 4, 2019
@SteveSandersonMS SteveSandersonMS added the area-blazor Includes: Blazor, Razor Components label Feb 6, 2019
@mkArtakMSFT mkArtakMSFT modified the milestones: 3.0.0, 3.0.0-preview5 Feb 6, 2019
@mkArtakMSFT mkArtakMSFT added the cost: L Will take from 5 - 10 days to complete label Feb 6, 2019
@rynowak rynowak added the Components Big Rock This issue tracks a big effort which can span multiple issues label Mar 4, 2019
@rynowak rynowak mentioned this issue Mar 4, 2019
Closed
56 tasks
@rynowak rynowak moved this from To do to In progress in Blazor Mar 16, 2019
@NTaylorMullen NTaylorMullen mentioned this issue Mar 19, 2019
Merged
@NTaylorMullen NTaylorMullen added Done This issue has been fixed and removed 2 - Working labels Mar 26, 2019
@NTaylorMullen
Copy link
Contributor

NTaylorMullen commented Mar 26, 2019 •
edited

1df8128b877ac9ffec5c7547e84927b0ecbe8c16
c9e0d2a60f7287d14c282555669b67a1000fef20
76c1352d2c4136ab4c3515ffca823377cbc7b2d9
ac08ad3659a14bad00eb9efffed59d99ff4eee2b

Blazor automation moved this from In progress to Done Mar 26, 2019
@rynowak
Copy link
Member Author

rynowak commented Mar 26, 2019

Are we missing test coverage for some of the lesser features? like range

@NTaylorMullen
Copy link
Contributor

Are we missing test coverage for some of the lesser features? like range

I'll add some.

NTaylorMullen added a commit to dotnet/razor that referenced this issue Mar 26, 2019
@NTaylorMullen
Add support for C# 8 using variable declarations and add more C# 8 co…
50b212d 
…verage.

- When adding additional C# 8 tests found that we didn't fully support this.
- Updated the C# 8.0 test to fully encompass everything C# 8.0.
- Added a feature flag to control using variable declaration errors when not top level.
- Added using variable declaration specific tests.

dotnet/aspnetcore#5092
NTaylorMullen added a commit to dotnet/razor that referenced this issue Mar 26, 2019
@NTaylorMullen
Add support for C# 8 using variable declarations and add more C# 8 co…
06a04cf 
…verage.

- When adding additional C# 8 tests found that we didn't fully support this.
- Updated the C# 8.0 test to fully encompass everything C# 8.0.
- Added a feature flag to control using variable declaration errors when not top level.
- Added using variable declaration specific tests.

dotnet/aspnetcore#5092
@NTaylorMullen NTaylorMullen mentioned this issue Mar 26, 2019
Merged
@NTaylorMullen
Copy link
Contributor

Are we missing test coverage for some of the lesser features? like range

Good thing you mentioned this. Found that we weren't perfect with using declaration syntax 👏

PR out: dotnet/razor#367

NTaylorMullen added a commit to dotnet/razor that referenced this issue Mar 26, 2019
@NTaylorMullen
Add support for C# 8 using variable declarations and add more C# 8 co…
6cf9ead 
…verage.

- When adding additional C# 8 tests found that we didn't fully support this.
- Updated the C# 8.0 test to fully encompass everything C# 8.0.
- Added a feature flag to control using variable declaration errors when not top level.
- Added using variable declaration specific tests.

dotnet/aspnetcore#5092
NTaylorMullen added a commit to dotnet/razor that referenced this issue Mar 27, 2019
@NTaylorMullen
Add support for C# 8 using variable declarations and add more C# 8 co…
ac08ad3 
…verage.

- When adding additional C# 8 tests found that we didn't fully support this.
- Updated the C# 8.0 test to fully encompass everything C# 8.0.
- Added a feature flag to control using variable declaration errors when not top level.
- Added using variable declaration specific tests.

dotnet/aspnetcore#5092
@NTaylorMullen
Copy link
Contributor

Done

@mkArtakMSFT mkArtakMSFT removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels May 9, 2019
@dotnet dotnet locked as resolved and limited conversation to collaborators Dec 3, 2019
@jaredpar jaredpar removed this from Done in Blazor Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
area-blazor Includes: Blazor, Razor Components Components Big Rock This issue tracks a big effort which can span multiple issues cost: L Will take from 5 - 10 days to complete Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-razor-pages
Projects
None yet
Milestone
3.0.0-preview4
Development

No branches or pull requests
6 participants
@SteveSandersonMS @rynowak @danroth27 @NTaylorMullen @mkArtakMSFT @aspnet-hello