Quarantine some tests #11420
Merged
Quarantine some tests #11420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't currently believe there's a product issue here and this is in the top-5 flaky.
davidfowl
approved these changes
Jun 20, 2019
analogrelay
changed the title
jkotalik
approved these changes
Jun 20, 2019
JunTaoLuo
approved these changes
Jun 20, 2019
halter73
approved these changes
Jun 20, 2019
halter73
reviewed
Jun 20, 2019
| @@ -102,6 +102,7 @@ public async Task GracefulShutdownWaitsForRequestsToFinish() | |||
| } | |||
|
|
|||
| [ConditionalFact] | |||
| [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2667", FlakyOn.All)] | |||
There was a problem hiding this comment.
See https://github.com/aspnet/AspNetCore-Internal/issues/2667#issuecomment-504206902 for my theory on why this is flaky.
ghost
deleted the
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't currently believe there's a product issue here and this is in the top-5 flaky.
(Do wait for a build, I need to verify that I didn't miss a namespace or something like that. I was having trouble getting my machine in a good state to build and decided to save that time by getting the PR out)