Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try updating SDK #8115

Merged
merged 1 commit into from Mar 4, 2019
Merged

Try updating SDK #8115

merged 1 commit into from Mar 4, 2019

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented Mar 1, 2019

@pakrym pakrym requested a review from natemcmaster March 1, 2019 23:30
@pakrym pakrym added the blocked The work on this issue is blocked due to some dependency label Mar 2, 2019
@pakrym
Copy link
Contributor Author

pakrym commented Mar 2, 2019

Blocked on dotnet/sdk#3002

@sebastienros
Copy link
Member

Do you mean you will take a newer sdk instead? But in that case you would just close this PR, so I don't get why it's blocked.

@pakrym
Copy link
Contributor Author

pakrym commented Mar 2, 2019

Ok, I'll close it after it fails.

@pakrym pakrym removed the blocked The work on this issue is blocked due to some dependency label Mar 2, 2019
@pakrym
Copy link
Contributor Author

pakrym commented Mar 2, 2019

Hm, it looks like it will pass. I guess we are not affected by the mentioned issue.

@sebastienros
Copy link
Member

Somehow expected, this SDK is much older (2 weeks), the latest is around 3.0.100-preview4-010553 and the issue only appeared yesterday. This is the one I was using on benchmarks.

I think we should still take it, and then the new one when it's ready, because there might be other issues with it.

@pakrym pakrym marked this pull request as ready for review March 2, 2019 03:31
@pakrym pakrym requested a review from sebastienros March 2, 2019 03:31
@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 3, 2019
@pakrym pakrym merged commit 51e30ee into master Mar 4, 2019
@natemcmaster natemcmaster deleted the pakrym/try-updating-sdk branch May 3, 2019 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienros sebastienros sebastienros approved these changes

@natemcmaster natemcmaster Awaiting requested review from natemcmaster

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pakrym @sebastienros @Eilon