Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add object pool for ServerSide RenderFrame serialization #5546

Closed
rynowak opened this issue Jul 13, 2018 · 2 comments
Closed

Add object pool for ServerSide RenderFrame serialization #5546

rynowak opened this issue Jul 13, 2018 · 2 comments
Labels
area-blazor Includes: Blazor, Razor Components task
Milestone
Backlog

Comments

@rynowak
Copy link
Member

rynowak commented Jul 13, 2018

Follow up item from #1116

We should consider pooling the byte arrays/streams from the render frame writer.
SteveSandersonMS referenced this issue in dotnet/blazor Aug 16, 2018
@SteveSandersonMS
Add pooling for MemoryStreams used in render batch serialization. Imp…
5d68566 
…lements #1132
SteveSandersonMS referenced this issue in dotnet/blazor Aug 16, 2018
@SteveSandersonMS
Add pooling for MemoryStreams used in render batch serialization. Imp…
224a98a 
…lements #1132
SteveSandersonMS referenced this issue in dotnet/blazor Aug 16, 2018
@SteveSandersonMS
Add pooling for MemoryStreams used in render batch serialization. Imp…
1f1b783 
…lements #1132
SteveSandersonMS referenced this issue in dotnet/blazor Aug 17, 2018
@SteveSandersonMS
Eliminate temporary MemoryStream buffers used during RenderBatch seri…
936f313 
…alization. Fixes #1132
SteveSandersonMS referenced this issue in dotnet/blazor Aug 21, 2018
@SteveSandersonMS
Eliminate temporary MemoryStream buffers used during RenderBatch seri…
aea4549 
…alization (#1329)

* Eliminate temporary MemoryStream buffers used during RenderBatch serialization. Fixes #1132

* CR: Fix namespace
@SteveSandersonMS
Copy link
Member

Reopening because we had to bring back the temporary buffer in #1666.

SteveSandersonMS referenced this issue in SteveSandersonMS/BlazorMigration Nov 27, 2018
@SteveSandersonMS
Eliminate temporary MemoryStream buffers used during RenderBatch seri…
52813dd 
…alization (dotnet#1329)

* Eliminate temporary MemoryStream buffers used during RenderBatch serialization. Fixes #1132

* CR: Fix namespace
@aspnet-hello aspnet-hello transferred this issue from dotnet/blazor Dec 17, 2018
@aspnet-hello aspnet-hello added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates area-blazor Includes: Blazor, Razor Components labels Dec 17, 2018
@danroth27 danroth27 added this to the Backlog milestone Apr 24, 2019
@mkArtakMSFT mkArtakMSFT removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels May 9, 2019
@pranavkm
Copy link
Contributor

This was addressed in 3.0. The rendering engine extensively uses ArrayPools

@dotnet dotnet locked as resolved and limited conversation to collaborators Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components task
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@pranavkm @SteveSandersonMS @rynowak @danroth27 @mkArtakMSFT @aspnet-hello