This repository has been archived by the owner on Feb 25, 2021. It is now read-only.
In RenderBatchWriter, deduplicate strings only when safe to do so #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We allow deduplication of HTML element and attribute names, plus whitespace text nodes / attribute values.
|
The AppVeyor failure is that it's failing to install Google Chrome. This has happened on AppVeyor before and continued until someone at AppVeyor (or maybe Chocolatey) updated something. |
rynowak
reviewed
Aug 21, 2018
| WriteString(frame.TextContent); | ||
| WriteString( | ||
| frame.TextContent, | ||
| allowDeduplication: string.IsNullOrWhiteSpace(frame.TextContent)); |
rynowak
approved these changes
Aug 21, 2018
SteveSandersonMS
deleted the
stevesa/renderbatch-size-reduction-the-cheap-parts
branch
SteveSandersonMS
added a commit
to SteveSandersonMS/BlazorMigration
that referenced
this pull request
Nov 27, 2018
…tnet#1340) We allow deduplication of HTML element and attribute names, plus whitespace text nodes / attribute values.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We allow deduplication of HTML element and attribute names, plus whitespace text nodes / attribute values.
This is a partial implementation of #1330. It's the only part we plan to include in 0.6.0; others will come later.