Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Support configuration "chaining", or adding one configuration to another #339

Closed
DamianEdwards opened this issue Nov 19, 2015 · 8 comments
Closed
Assignees
Milestone

Comments

@DamianEdwards
Copy link
Member

Required to support aspnet/Hosting#448

Add support for adding one IConfiguration to another, e.g.:

public Startup(IHostingEnvironment hosting)
{
    var builder = new ConfigurationBuilder()
        .AddJsonFile("appsettings.json")
        .AddEnvironmentVariables()
        .AddConfiguration(hosting.Configuration);

    Configuration = builder.Build();
}

Should have two extension method overloads:

public static IConfigurationBuilder AddConfiguration(this IConfigurationBuilder builder, IConfiguration configuration);
public static IConfigurationBuilder AddConfiguration(this IConfigurationBuilder builder, string prefix, IConfiguration configuration);
@davidfowl
Copy link
Member

/cc @divega

@divega
Copy link

divega commented Nov 19, 2015

Cool. A ConfigurationConfigurationProvider 😏 Is this needed in RC2?

@davidfowl
Copy link
Member

Yes

@DamianEdwards
Copy link
Member Author

@divega can you assign please?

@divega
Copy link

divega commented Nov 21, 2015

Figuring out with @Eilon who will work on this.

@divega
Copy link

divega commented Nov 22, 2015

Assigning to @HaoK. Hopefully he can start in a few days.

@HaoK
Copy link
Member

HaoK commented Jan 7, 2016

2909753

@HaoK HaoK closed this as completed Jan 7, 2016
@HaoK HaoK added 3 - Done and removed 2 - Working labels Jan 7, 2016
@andriysavin
Copy link

Hi everybody. I can't find this provider in v2.0, where did it go?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants