Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Remove ConfigurationBuilder.Add(provider, load) overload #351

Closed
divega opened this issue Dec 9, 2015 · 2 comments
Closed

Remove ConfigurationBuilder.Add(provider, load) overload #351

divega opened this issue Dec 9, 2015 · 2 comments
Assignees
@HaoK
Labels
3 - Done bug
Milestone
1.0.0-rc2

Comments

@divega
Copy link

divega commented Dec 9, 2015

A bunch of tests call this overload passing an in-memory provider and load: false but this seems complete superfluous as MemoryConfigurationProvider.Load() is a no-op anyway.

It doesn't seem to be used anywhere and IConfigurationBuilder doesn't define it. So it is most likely just leftover from a previous design iteration that we can get rid of.
@divega divega mentioned this issue Dec 9, 2015
Closed
@divega
Copy link
Author

divega commented Dec 9, 2015

Unless @lodejard remember a reason we need it.

@HaoK HaoK self-assigned this Mar 30, 2016
@HaoK
Copy link
Member

HaoK commented Mar 31, 2016

30e59f1

@HaoK HaoK closed this as completed Mar 31, 2016
@HaoK HaoK added this to the 1.0.0-rc2 milestone Mar 31, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HaoK HaoK

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-rc2
Development

No branches or pull requests
2 participants
@divega @HaoK