Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M.A.App should be version-less #8579

Closed
Rick-Anderson opened this issue Sep 18, 2018 — with docs.microsoft.com · 4 comments
Closed

M.A.App should be version-less #8579

Rick-Anderson opened this issue Sep 18, 2018 — with docs.microsoft.com · 4 comments
Assignees
Labels
Pri1 High priority, do before Pri2 and Pri3 Source - Docs.ms Docs Customer feedback via GitHub Issue

Comments

Copy link
Contributor

Rick-Anderson commented Sep 18, 2018

The templates don't generate a version. This sample shouldn't.
See this PR to backout changes


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@Rick-Anderson Rick-Anderson self-assigned this Sep 18, 2018
@Rick-Anderson Rick-Anderson added Pri1 High priority, do before Pri2 and Pri3 Source - Docs.ms Docs Customer feedback via GitHub Issue labels Sep 18, 2018
@Rick-Anderson Rick-Anderson added this to the Sprint 141 (9/3 to 9/21) milestone Sep 18, 2018
@Rick-Anderson Rick-Anderson added this to To do in Sprint 141 (9/3 - 9/21) via automation Sep 18, 2018
@guardrex
Copy link
Collaborator

@Rick-Anderson @scottaddie So was it as of the 2.1.3 release that they went back to implicit versioning? If so, then let me know if you'd like me to run back thru the samps and drop the versions from App package references.

@Rick-Anderson
Copy link
Contributor Author

I'll find out next Tuesday when @natemcmaster returns from VAC. Can you remind me then? I'm guessing yes.

@guardrex
Copy link
Collaborator

@Rick-Anderson Reminder to ask Nate about adding back the versions to our App package refs.

@natemcmaster
Copy link
Contributor

After lots of discussion and experimentation, we are going to stick with original design -- versionless PackageReference is the recommended way to use Microsoft.AspNetCore.App. We should update our docs and guidance to match this recommendation.

Just FYI - we implemented and tested alternatives ways to reference the Microsoft.AspNetCore.App shared framework. While these might have been accepted if we had done them in the first place, we did not feel the benefits of switching approaches outweighed the costs. This was especially true as we began to design 3.0. In 3.0, we plan to rework the way shared frameworks are referenced in projects. Rather than introducing more churn, we're going to make some improvements in the 2.2 SDK for using the versionless PackageReference (see dotnet/sdk#2533), and will focus our efforts on making 3.0 better.

Sprint 141 (9/3 - 9/21) automation moved this from To do to Done Sep 26, 2018
Rick-Anderson pushed a commit that referenced this issue Oct 7, 2018
Addresses #8579 

I might be getting the hang of **_find and replace_** now. 😝

This doesn't touch a couple that ref 2.2.0. I'll tidy those up on #8518 after 2.2 RTM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pri1 High priority, do before Pri2 and Pri3 Source - Docs.ms Docs Customer feedback via GitHub Issue
Projects
No open projects
Development

No branches or pull requests

3 participants