Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app-state.md #2872

Merged
merged 2 commits into from Mar 3, 2017
Merged

Update app-state.md #2872

merged 2 commits into from Mar 3, 2017

Conversation

DianaLaRose
Copy link
Contributor

Edited the intro blurb and the first major header plus its one subhead.

Edited the intro blurb and the first major header plus its one subhead.
@dnfclas
Copy link

dnfclas commented Mar 3, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Copy link
Contributor

@Rick-Anderson Rick-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding

@Rick-Anderson Rick-Anderson merged commit 0425b2b into dotnet:master Mar 3, 2017
@DianaLaRose
Copy link
Contributor Author

DianaLaRose commented Mar 3, 2017 via email

@@ -16,28 +16,26 @@ ms.custom: H1Hack27Feb2017

# Introduction to session and application state in ASP.NET Core

By [Rick Anderson](https://twitter.com/RickAndMSFT) and [Steve Smith](http://ardalis.com)
By [Rick Anderson](https://twitter.com/RickAndMSFT), [Steve Smith](http://ardalis.com) and [Diana LaRose](https://github.com/DianaLaRose)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DianaLaRose Hi -- Lists were following the Oxford/Harvard/Serial comma rule ... unless something has changed. Two spaces won't be rendered, but the practice has been to eliminate them when discovered. There's one double-space on this line and three below in the new text

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi - I didn't make that particular change, but thanks for letting me know about double spaces. I had been ignoring them because they don't render. As for serial commas: yes, they're definitely the rule.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry ... I should've checked the commit history.

Rick did that! ... He's testing me. 😄 He wants to make sure I'm still on the ⚽️.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants