New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update app-state.md #2872
Update app-state.md #2872
Conversation
Edited the intro blurb and the first major header plus its one subhead.
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding
Cool, I'm glad!
…________________________________
From: Rick Anderson <notifications@github.com>
Sent: Thursday, March 2, 2017 7:51 PM
To: aspnet/Docs
Cc: Diana LaRose; Author
Subject: Re: [aspnet/Docs] Update app-state.md (#2872)
@Rick-Anderson approved this pull request.
Outstanding
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#2872 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AYLYvQQpepuYX4Paza_bccGV5LGEmzHgks5rh44ygaJpZM4MRx58>.
|
@@ -16,28 +16,26 @@ ms.custom: H1Hack27Feb2017 | |||
|
|||
# Introduction to session and application state in ASP.NET Core | |||
|
|||
By [Rick Anderson](https://twitter.com/RickAndMSFT) and [Steve Smith](http://ardalis.com) | |||
By [Rick Anderson](https://twitter.com/RickAndMSFT), [Steve Smith](http://ardalis.com) and [Diana LaRose](https://github.com/DianaLaRose) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DianaLaRose Hi -- Lists were following the Oxford/Harvard/Serial comma rule ... unless something has changed. Two spaces won't be rendered, but the practice has been to eliminate them when discovered. There's one double-space on this line and three below in the new text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi - I didn't make that particular change, but thanks for letting me know about double spaces. I had been ignoring them because they don't render. As for serial commas: yes, they're definitely the rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry ... I should've checked the commit history.
Rick did that! ... He's testing me. 😄 He wants to make sure I'm still on the ⚽️.
Edited the intro blurb and the first major header plus its one subhead.