Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define patterns/APIs for using configuration #192

Closed
rowanmiller opened this issue May 22, 2014 · 8 comments
Closed

Define patterns/APIs for using configuration #192

rowanmiller opened this issue May 22, 2014 · 8 comments
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@rowanmiller
Copy link
Contributor

No description provided.

@rowanmiller rowanmiller added this to the 1.0.0 milestone May 22, 2014
@rowanmiller rowanmiller modified the milestones: 1.0.0-beta1, 1.0.0 Jun 20, 2014
@rowanmiller rowanmiller changed the title Define patterns/APIs for using configuration from ASP.NET vNext [Beta Must Have] Define patterns/APIs for using using configuration Jun 20, 2014
@AndriySvyryd AndriySvyryd changed the title [Beta Must Have] Define patterns/APIs for using using configuration [Beta Must Have] Define patterns/APIs for using configuration Sep 26, 2014
@divega
Copy link
Contributor

divega commented Oct 13, 2014

It seems that the main things missing for now are:

  1. Read relevant DbContextOptions from IConfiguration #849 Read relevant DbContextOptions from configuration (beta1, @emilcicos )
  2. AddEntityFramework(IConfiguration) should enable service replacement from Configuration #829 Add AddEntityFramework(ICofiguration) overload that initializes services from configuration (rc1, @emilcicos )
  3. Migrations: Add MigrationsDirectory to DbContextOptions #627 Add MigrationsDirectory to DbContextOptions (beta1, @bricelam)
  4. Scrub EF codebase for direct access to configuration. Possibly the main thing is to replace the existing ConnectionStringResolver with the result of Read relevant DbContextOptions from IConfiguration #849. @AndriySvyryd do we still have code to read maximum batch size from configuration?

Moving the ownership of this to @emilcicos.

@divega divega assigned ghost and unassigned divega Oct 13, 2014
@AndriySvyryd
Copy link
Member

Yes, we read the maximum batch size from configuration in the SqlServerModificationCommandBatchFactory

@divega
Copy link
Contributor

divega commented Oct 14, 2014

Thanks @AndriySvyryd. I filed #865.

@ghost ghost modified the milestones: 1.0.0-rc1, 1.0.0-beta1 Oct 17, 2014
@divega divega changed the title [Beta Must Have] Define patterns/APIs for using configuration Define patterns/APIs for using configuration Oct 21, 2014
@ghost
Copy link

ghost commented Nov 20, 2014

The remaining things to be done here are:

  1. Read more options from configuration (currently only the connection string is read)
  2. Work item 4. above.

@divega
Copy link
Contributor

divega commented Nov 26, 2014

@rowanmiller it looks like besides #849 we need to clean up the places where EF code depends directly on IConfiguration (item 4. above). Would you mind if I assign both to @smitpatel?

@rowanmiller
Copy link
Contributor Author

@divega Sounds good to me

@divega
Copy link
Contributor

divega commented Nov 27, 2014

@smitpatel please once #865 and #849 are closed also scrub the rest of the EF and EF provider code for direct dependencies on IConfiguration being resolvable through DI.

@smitpatel
Copy link
Member

Finished with b73ce88 & 91436f6

@rowanmiller rowanmiller modified the milestones: 7.0.0, 7.0.0-beta6 Jul 15, 2015
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2022
@ajcvickers ajcvickers modified the milestones: 1.0.0-beta6, 1.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

No branches or pull requests

5 participants