Migrations generate wrong order for DropForeignKey and DropPrimaryKey

[andre-artus]

I changed the name of a column in a small database (on SQL Server 2014) I'm using to test EF7 and used "Add-Migration" to generate the code.

Running "Apply-Migration" I received the following error:

"The constraint 'PK_Address' is being referenced by table 'Meter', foreign key constraint 'FK_Meter_Address_AddressAddressId'"

Looking at the code that was generated I noticed that in the "Up" method the call to "DropPrimaryKey" came before the calls to "DropForeignKey".

migration.DropPrimaryKey(name: "PK_Address", table: "Address");
migration.DropForeignKey(name: "FK_Meter_Address_AddressAddressId", table: "Meter");

Dropping foreign keys before the primary key worked as expected.

IDE: VS 2015 RC
EF: 7.0.0-beta4
Project types: Console & Class Library
Windows 8.1

Not sure what other information may prove useful.

[andre-artus]

I would like to point out that the same is happening in the "Down" method.

[bricelam]

😄 I fixed that just as you were filing the issue.

[andre-artus]

Was it an open issue already? I did a search in the issues prior to filing, did not see anything that seemed to fit the bill. Thanks for fixing it, where in the code was the issue?

[bricelam]

No issue; I found it while adding test coverage. It was an oversight in the ModelDiffer.Sort() method.