Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndentedStringBuilder shouldn't create space-only lines #654

Closed
bricelam opened this issue Sep 12, 2014 · 0 comments
Closed

IndentedStringBuilder shouldn't create space-only lines #654

bricelam opened this issue Sep 12, 2014 · 0 comments
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. good first issue This issue should be relatively straightforward to fix. help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. type-enhancement
Milestone

Comments

@bricelam
Copy link
Contributor

Steps

var builder = new IndentedStringBuilder();
using (builder.Indent())
    builder.AppendLine();
return builder.ToString();

Result

"    \r\n"

Expected

"\r\n"

The extra characters are a waste of space. 馃槈 We currently use IndentedStringBuilder in the following areas.

  • Migrations
    • Code
    • DDL
  • Query
    • SQL
@rowanmiller rowanmiller added this to the 1.0.0 milestone Sep 19, 2014
@bricelam bricelam self-assigned this Nov 25, 2014
@rowanmiller rowanmiller modified the milestones: Backlog, 7.0.0 Dec 5, 2014
@bricelam bricelam removed their assignment Dec 9, 2014
@bricelam bricelam added the help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. label May 15, 2015
@bricelam bricelam modified the milestones: 7.0.0-beta5, Backlog May 26, 2015
@bricelam bricelam self-assigned this May 26, 2015
@bricelam bricelam modified the milestones: 7.0.0, 7.0.0-beta5 May 26, 2015
@bricelam bricelam modified the milestones: 7.0.0-beta6, 7.0.0 Jun 4, 2015
@bricelam bricelam added the good first issue This issue should be relatively straightforward to fix. label May 31, 2019
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2022
@ajcvickers ajcvickers modified the milestones: 1.0.0-beta6, 1.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. good first issue This issue should be relatively straightforward to fix. help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. type-enhancement
Projects
None yet
Development

No branches or pull requests

3 participants