New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query: Port Include() performance improvement to 1.0.2 #6760
Comments
In general, I think the releases should be more often and release as soon as possible. An example (from the MVC repo) @dougbu: aspnet/Mvc@cbc88fc Please bear in mind there are real applications out there, which crucially need those fixed merged, and 4 months or even more to wait is sometimes unacceptable, depending on the severity. Thanks for considering it @divega ! |
@anpete can you evaluate the risk on this one |
@rowanmiller Low risk. I think we can take it. |
Cool, can you port the fix into 1.0.2 |
Merged |
Thanks 👍 👍 👍 |
This patch is approved, please ensure it is merged into the correct branch and building as part of the patch train. |
This is already in all the right branches. |
@Eilon @divega Can you share a ~ release date of 1.0.2? (Safari for some reason doesn't respect form validations (for 9 years!) and a very important customer of ours submitted an invalid form and MVC couldn't show him the errors because the required field was in a collection) |
@gdoron hopefully soon 😄 We're nearly done writing the code, but we have to do verification of the bits first. We have a package feed with nightly builds at https://dotnet.myget.org/gallery/aspnetcore-patch, but the builds for this release aren't there yet (we're working on it right now). |
@Eilon, for some reason, we can't use the nightly builds. Can you please assign someone to take a look? I can give him an access to our private GitHub repository (Yes, we are desperate...) so it won't be a trial and error. p.s. It's for a very good cause, ASP.NET Core is not just saving kittens 😸 but helping people with disabilities at yooocan.com 💪. |
@gdoron well if you do manage to get nightly builds working, we have some builds on this feed: https://dotnet.myget.org/gallery/aspnetcore-patch As far as dates, we're nearly done with the code, but the actual release involves a number of teams coordinating lots of builds so we can't guarantee any particular dates. BTW very cool project you're working on! |
We made a fix in d013493 that significantly improves the performance of certain queries with
Include()
.We should check if it meets the risk bar for a patch release.
The text was updated successfully, but these errors were encountered: