Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExecutionStrategy ctor argument - maxRetryCount has incorrect documentation #6828

Closed
maumar opened this issue Oct 21, 2016 · 4 comments
Closed

ExecutionStrategy ctor argument - maxRetryCount has incorrect documentation #6828

maumar opened this issue Oct 21, 2016 · 4 comments
Assignees
@smitpatel
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
2.0.0

Comments

@maumar
Copy link
Contributor

maumar commented Oct 21, 2016

Documentation says:

The maximum delay in milliseconds between retries.

but the argument is TimeSpan.

We should change the message to:

The maximum delay between retries.
@rowanmiller rowanmiller added this to the 1.1.0 milestone Oct 24, 2016
@rowanmiller rowanmiller self-assigned this Oct 24, 2016
@AndriySvyryd
Copy link
Member

There are 5 places where this needs to be changed.

@rowanmiller rowanmiller modified the milestones: 1.1.0, 1.2.0 Nov 7, 2016
@ajcvickers ajcvickers modified the milestones: 2.0.0-preview1, 2.0.0 Apr 19, 2017
@smitpatel
Copy link
Member

Can I poach this? :trollface:

@smitpatel smitpatel assigned smitpatel and unassigned AndriySvyryd Apr 28, 2017
@smitpatel
Copy link
Member

@AndriySvyryd - Suggested doc comment here?
The maximum delay between retries. ? or do we want to include timespan too?

@AndriySvyryd
Copy link
Member

Timespan is implied, so the first suggestion should be ok.

@smitpatel smitpatel mentioned this issue Apr 28, 2017
Merged
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Apr 28, 2017
@bricelam bricelam modified the milestones: 2.0.0, 2.0.0-preview2 May 16, 2017
@ajcvickers ajcvickers modified the milestones: 2.0.0-preview2, 2.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
6 participants
@bricelam @ajcvickers @smitpatel @maumar @rowanmiller @AndriySvyryd