Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Better warning and XML doc comments about ignored Includes #7162

Closed
rowanmiller opened this issue Nov 30, 2016 · 1 comment
Closed

Query: Better warning and XML doc comments about ignored Includes #7162

rowanmiller opened this issue Nov 30, 2016 · 1 comment
Labels
area-docs closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
2.0.0

Comments

@rowanmiller
Copy link
Contributor

Suggestion from @mguinness to make the warning clearer. We could also FWLink to the docs on this topic.

The Include operation for navigation: 'c.State' is unnecessary and
was ignored because the target navigation is not reachable in the final query results.

We should also doc when include is/isn't needed in the xml comments for Include.
@rowanmiller rowanmiller added this to the 1.2.0 milestone Nov 30, 2016
@rowanmiller rowanmiller self-assigned this Nov 30, 2016
@rowanmiller rowanmiller mentioned this issue Nov 30, 2016
Closed
@rowanmiller
Copy link
Contributor Author

We can FWLink to https://docs.microsoft.com/en-us/ef/core/querying/related-data#ignored-includes

@rowanmiller rowanmiller assigned divega and unassigned rowanmiller Mar 10, 2017
@ajcvickers ajcvickers modified the milestones: 2.0.0-preview1, 2.0.0 Apr 19, 2017
@divega divega closed this as completed in 8f56d15 Jun 9, 2017
divega added a commit that referenced this issue Jun 9, 2017
@divega
Simplified ignored include message. Fixes #7162.
02d78f8
@divega divega added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement area-docs and removed type-bug labels Jun 9, 2017
@MNF MNF mentioned this issue Apr 23, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-docs closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@divega @ajcvickers @rowanmiller