Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trace connection open and close in RelationalConnection #7479

Closed
fitzchak opened this issue Jan 25, 2017 · 2 comments
Closed

Trace connection open and close in RelationalConnection #7479

fitzchak opened this issue Jan 25, 2017 · 2 comments
Assignees
@anpete
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
2.0.0

Comments

@fitzchak
Copy link

RelationalCommand has tracing but RelationalConnection connection is missing.
Adding ConnectionOpened and ConnectionClosed will help us trace this events in order to integrate with EntityFrameworkProfiler.
A PR is on the way.
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 25, 2017
dotnet#7479 Trace connection open and close in RelationalConnection
54673c3
@fitzchak fitzchak mentioned this issue Jan 25, 2017
Merged
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 26, 2017
dotnet#7479 Trace connection open and close in RelationalConnection
e125cd7
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 26, 2017
dotnet#7479 Trace connection open and close in RelationalConnection
f6bef29
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 26, 2017
dotnet#7479 Trace connection open and close in RelationalConnection
00163c2
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 26, 2017
dotnet#7479 Trace connection open and close in RelationalConnection
23f83e0
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 26, 2017
dotnet#7479 Trace connection open and close in RelationalConnection
f0aaf40
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 26, 2017
dotnet#7479 Trace connection open and close in RelationalConnection
4acff23
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 26, 2017
dotnet#7479 Trace transaction committed / rolled back / created / dis…
07dce52 
…posed.
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 26, 2017
dotnet#7479 Add connection identifier.
f509920
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 26, 2017
dotnet#7479 Trace errors. It will include all connection / transactio…
c73facd 
…n / commands errors which happened in the connection's scope.
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 29, 2017
dotnet#7479 Trace errors. It will include all connection / transactio…
aefc4b4 
…n errors which happened in the connection's scope.
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 29, 2017
dotnet#7479 Trace the beginning of each connection and have a dedicat…
609b2e5 
…ed ConnectionError. Also trace more info: executionTime, Duration and InstanceId.

Also trace more info in the transaction Commit and Rollback: executionTime, Duration and add dedicated transaction error method.
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 29, 2017
dotnet#7479 Trace connection open and close in RelationalConnection
85c0643
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 29, 2017
dotnet#7479 Trace transaction committed / rolled back / created / dis…
86ee79e 
…posed.
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 29, 2017
dotnet#7479 Add connection identifier.
6bec330
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 29, 2017
dotnet#7479 Trace errors. It will include all connection / transactio…
fce2af4 
…n errors which happened in the connection's scope.
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 29, 2017
dotnet#7479 Trace the beginning of each connection and have a dedicat…
df9ace4 
…ed ConnectionError. Also trace more info: executionTime, Duration and InstanceId.

Also trace more info in the transaction Commit and Rollback: executionTime, Duration and add dedicated transaction error method.
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 31, 2017
dotnet#7479 Trace the beginning of each connection and have a dedicat…
8ca956e 
…ed ConnectionError. Also trace more info: executionTime, Duration and InstanceId.

Also trace more info in the transaction Commit and Rollback: executionTime, Duration and add dedicated transaction error method.
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 31, 2017
dotnet#7479 Make the RelationalConnection.ConnectionId virtual and xm…
a041483 
…l documented.
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 31, 2017
dotnet#7479 Add tracing info to DataReaderDisposing: The actual conne…
2bdfd2f 
…ction, the RecordsAffected, Timestamp and Duration
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 31, 2017
dotnet#7479 Add tracing info to WriteCommandAfter: The results of exe…
56b0ede 
…cuted method, which will be in affected rows in case of method ExecuteNonQuery
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 31, 2017
dotnet#7479 Trace connection open and close in RelationalConnection
2ff3bb4
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 31, 2017
dotnet#7479 Trace transaction committed / rolled back / created / dis…
c813d76 
…posed.
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 31, 2017
dotnet#7479 Add connection identifier.
a1c2851
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 31, 2017
dotnet#7479 Trace errors. It will include all connection / transactio…
3f7bfec 
…n errors which happened in the connection's scope.
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 31, 2017
dotnet#7479 Trace the beginning of each connection and have a dedicat…
a1ccf3c 
…ed ConnectionError. Also trace more info: executionTime, Duration and InstanceId.

Also trace more info in the transaction Commit and Rollback: executionTime, Duration and add dedicated transaction error method.
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 31, 2017
dotnet#7479 Make the RelationalConnection.ConnectionId virtual and xm…
067ef0c 
…l documented.
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 31, 2017
dotnet#7479 Add tracing info to DataReaderDisposing: The actual conne…
67ee1c4 
…ction, the RecordsAffected, Timestamp and Duration
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Jan 31, 2017
dotnet#7479 Add tracing info to WriteCommandAfter: The results of exe…
b16ec4b 
…cuted method, which will be in affected rows in case of method ExecuteNonQuery
@rowanmiller rowanmiller added this to the 2.0.0 milestone Jan 31, 2017
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Feb 1, 2017
dotnet#7479 Add transaction identifier info the the commands tracing …
52556e4 
…and the transaction itself which can be fetched from IDbContextTransaction using reflection

Also #Use anonymous types as all the other traces and per the comment on RelationalDiagnosticSourceAfterMessage.
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Feb 28, 2017
dotnet#7479 Add transaction identifier info the the commands tracing …
2bca7f5 
…and the transaction itself which can be fetched from IDbContextTransaction using reflection

Also #Use anonymous types as all the other traces and per the comment on RelationalDiagnosticSourceAfterMessage.
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Mar 26, 2017
dotnet#7479 Add transaction identifier info the the commands tracing …
765adcb 
…and the transaction itself which can be fetched from IDbContextTransaction using reflection

Also #Use anonymous types as all the other traces and per the comment on RelationalDiagnosticSourceAfterMessage.
fitzchak pushed a commit to fitzchak/EntityFramework that referenced this issue Mar 26, 2017
dotnet#7479 Add transaction identifier info the the commands tracing …
1759f41 
…and the transaction itself which can be fetched from IDbContextTransaction using reflection

Also #Use anonymous types as all the other traces and per the comment on RelationalDiagnosticSourceAfterMessage.
@ajcvickers ajcvickers reopened this Apr 4, 2017
@ajcvickers ajcvickers mentioned this issue Apr 4, 2017
Closed
@ajcvickers
Copy link
Member

Re-opening since community PR to complete this was not building and we decided to track the work as a regular issue.

@ajcvickers ajcvickers modified the milestones: 2.0.0-preview1, 2.0.0 Apr 19, 2017
@anpete
Copy link
Contributor

anpete commented May 11, 2017

Closing as I think @ajcvickers has fully addressed this with the recent diagnostics work.

@anpete anpete closed this as completed May 11, 2017
@anpete anpete added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label May 11, 2017
@bricelam bricelam modified the milestones: 2.0.0, 2.0.0-preview2 May 16, 2017
@ajcvickers ajcvickers modified the milestones: 2.0.0-preview2, 2.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anpete anpete

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
5 participants
@fitzchak @anpete @bricelam @ajcvickers @rowanmiller