Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools: Port #7889 to 1.1.1 #8142

Closed
bricelam opened this issue Apr 12, 2017 · 5 comments
Closed

Tools: Port #7889 to 1.1.1 #8142

bricelam opened this issue Apr 12, 2017 · 5 comments
Assignees
@bricelam
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
1.1.2

Comments

@bricelam
Copy link
Contributor

The 1.0.1 tools fix for #7889 should be ported to 1.1.1
@bricelam bricelam added this to the tools/1.1.1 milestone Apr 12, 2017
@bricelam bricelam self-assigned this Apr 12, 2017
@ajcvickers
Copy link
Member

@bricelam Forgive me for not keeping this all straight, but should this then ship as part of the upcoming 1.1.2 patch?

@bricelam
Copy link
Contributor Author

Yes, I was going to check with you and @Eilon about what milestone these should be in...

@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Apr 18, 2017
@bricelam bricelam modified the milestones: 1.1.2, tools/1.1.1 Apr 18, 2017
@bricelam
Copy link
Contributor Author

Tracking in the corresponding EntityFramework milestones for simplicity. The patch build system has been updated to do the right thing.

@ajcvickers
Copy link
Member

ajcvickers commented Apr 18, 2017 •
edited

@Eilon @bricelam Looking at #7889 an seeing that a "ton of people" are hitting this, and given that we already have the fix coded and just need to port it, I think we should get approval for this in 1.1.2.

@ajcvickers ajcvickers mentioned this issue Apr 19, 2017
Closed
@Eilon
Copy link
Member

Eilon commented Apr 23, 2017

This patch fix is approved. Please follow the normal code review / pull request process and make sure you make the change in the correct branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
1.1.2
Development

No branches or pull requests
3 participants
@Eilon @bricelam @ajcvickers