Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak in LocalView #8144

Closed
AndriySvyryd opened this issue Apr 12, 2017 · 0 comments
Closed

Memory leak in LocalView #8144

AndriySvyryd opened this issue Apr 12, 2017 · 0 comments
Assignees
@ajcvickers
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
2.0.0

Comments

@AndriySvyryd
Copy link
Member

Each time we create a LocalView instance we call ILocalViewListener.RegisterView, but don't ever deregister them.
Also we cache LocalView instances in DbSet, but we don't cache DbSet instances returned by DbContext.Set
@ajcvickers ajcvickers self-assigned this Apr 14, 2017
@ajcvickers ajcvickers modified the milestones: 2.0.0, 2.0.0-preview1 Apr 14, 2017
ajcvickers added a commit that referenced this issue Jun 12, 2017
@ajcvickers
Cache DbSet objects to prevent memory leaks when DbSets cache local v…
e01b067 
…iews

Issue #8144

I don't think that there is any issue not un-registering the listeners, since LocalView objects always have the same lifetime as the underlying context. I added checks so that the LocalView will throw if it is being used with a disposed context.
@ajcvickers ajcvickers mentioned this issue Jun 12, 2017
Merged
ajcvickers added a commit that referenced this issue Jun 15, 2017
@ajcvickers
Cache DbSet objects to prevent memory leaks when DbSets cache local v…
584fc4d 
…iews

Issue #8144

I don't think that there is any issue not un-registering the listeners, since LocalView objects always have the same lifetime as the underlying context. I added checks so that the LocalView will throw if it is being used with a disposed context.
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajcvickers ajcvickers

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@ajcvickers @AndriySvyryd