Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error on ignored includes #8398

Closed
ajcvickers opened this issue May 6, 2017 · 3 comments
Closed

Throw error on ignored includes #8398

ajcvickers opened this issue May 6, 2017 · 3 comments
Assignees
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@ajcvickers
Copy link
Member

We currently warn when a query has an Include call that is ignored. We decided to change this to throw by default, with the ability to switch back to a warning. This is because the cases where people are intentionally and knowingly ignoring includes is much less common that the cases where the include should just be removed.

@ajcvickers ajcvickers self-assigned this May 6, 2017
@ajcvickers ajcvickers added this to the 2.0.0 milestone May 6, 2017
@ajcvickers ajcvickers modified the milestones: 2.0.0, 2.0.0-preview2 May 15, 2017
@ajcvickers
Copy link
Member Author

@divega Can we get a fwlink for this? Probably just pointing to https://docs.microsoft.com/en-us/ef/core/querying/related-data unless you think that it would be better to have a special page? (Either way, if we get a fwlink now we can change where it points later.)

(Rowan always got fwlinks for me, so now I am asking you. 😸)

@divega
Copy link
Contributor

divega commented May 24, 2017

@ajcvickers We already had http://go.microsoft.com/fwlink/?LinkID=746393 pointing to that page for ambiguous one-to-one, but I went ahead and created a new one https://go.microsoft.com/fwlink/?linkid=850303, in case some day we decide we need a special page.

@divega
Copy link
Contributor

divega commented May 24, 2017

I tweaked it a bit more. It now points to https://docs.microsoft.com/en-us/ef/core/querying/related-data#eager-loading.

ajcvickers added a commit that referenced this issue May 25, 2017
Issue #8398

The warning is now configured to throw by default.
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label May 25, 2017
@ajcvickers ajcvickers modified the milestones: 2.0.0-preview2, 2.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

No branches or pull requests

2 participants