-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query: compilation error for queries with navigations inside set result operators and Count #8525
Labels
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-bug
Milestone
Comments
those query sources are not marked for materialization (because of Count), but it seems that Concat result operator require them to be materialized |
maumar
added a commit
that referenced
this issue
Jul 1, 2017
#8524 - Query: data corruption for queries with set result operators (Concat/Union etc) and collection navigations #8525 - Query: compilation error for queries with navigations inside set result operators and Count #9004 - Query: compilation error for queries with Concat on two entities and Count Problem was that for set result operators we always need to materialize both sets, even if they are wrapped around scalar result operator (e.g. Count). This is needed because set result operators are currently performed on the client. Also, we need to inject MaterializeCollectionNavigation calls into set result operators, so that the IQuerySource that is the argument to the set operator is wrapped in its own query source. Also fixed some minor bugs in the MaterializeCollectionNavigation injector, which surfaced once the visitor started going inside SubQueryExpressions (it wasn't necessary before because we only needed to materialize top level collection).
maumar
added a commit
that referenced
this issue
Jul 3, 2017
#8524 - Query: data corruption for queries with set result operators (Concat/Union etc) and collection navigations #8525 - Query: compilation error for queries with navigations inside set result operators and Count #9004 - Query: compilation error for queries with Concat on two entities and Count Problem was that for set result operators we always need to materialize both sets, even if they are wrapped around scalar result operator (e.g. Count). This is needed because set result operators are currently performed on the client. Also, we need to inject MaterializeCollectionNavigation calls into set result operators, so that the IQuerySource that is the argument to the set operator is wrapped in its own query source. Also fixed some minor bugs in the MaterializeCollectionNavigation injector, which surfaced once the visitor started going inside SubQueryExpressions (it wasn't necessary before because we only needed to materialize top level collection).
maumar
added a commit
that referenced
this issue
Jul 5, 2017
#8524 - Query: data corruption for queries with set result operators (Concat/Union etc) and collection navigations #8525 - Query: compilation error for queries with navigations inside set result operators and Count #9004 - Query: compilation error for queries with Concat on two entities and Count Problem was that for set result operators we always need to materialize both sets, even if they are wrapped around scalar result operator (e.g. Count). This is needed because set result operators are currently performed on the client. Also, we need to inject MaterializeCollectionNavigation calls into set result operators, so that the IQuerySource that is the argument to the set operator is wrapped in its own query source. Also fixed some minor bugs in the MaterializeCollectionNavigation injector, which surfaced once the visitor started going inside SubQueryExpressions (it wasn't necessary before because we only needed to materialize top level collection).
fixed in e1d7b16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-bug
query:
throws:
The text was updated successfully, but these errors were encountered: