Query/Test: introduce client-side ordering to QueryTests without explicit orderby, rather than using contains in the result verification #8617
Assignees
Labels
area-test
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-enhancement
Milestone
Comments
|
related to #8606 |
maumar
added a commit
that referenced
this issue
Jun 23, 2017
…ts without explicit orderby, rather than using contains in the result verification This PR includes: - applying client side ordering to QueryTests (rather than doing O(n^2) result comparisons for queries without order by, - adding entry count verification (we had it in some places and not in others), - DRYing some of the commonly used asserters As a result, time to run those tests is cut down in half (40s to 20s). For now the helper methods are duplicated with the ones used in complex navs - will unify them in next checkin.
maumar
added a commit
that referenced
this issue
Jun 23, 2017
…ts without explicit orderby, rather than using contains in the result verification This PR includes: - applying client side ordering to QueryTests (rather than doing O(n^2) result comparisons for queries without order by, - adding entry count verification (we had it in some places and not in others), - DRYing some of the commonly used asserters As a result, time to run those tests is cut down in half (40s to 20s). For now the helper methods are duplicated with the ones used in complex navs - will unify them in next checkin.
maumar
added a commit
that referenced
this issue
Jun 23, 2017
…ts without explicit orderby, rather than using contains in the result verification This PR includes: - applying client side ordering to QueryTests (rather than doing O(n^2) result comparisons for queries without order by, - adding entry count verification (we had it in some places and not in others), - DRYing some of the commonly used asserters As a result, time to run those tests is cut down in half (40s to 20s). For now the helper methods are duplicated with the ones used in complex navs - will unify them in next checkin.
maumar
added a commit
that referenced
this issue
Jun 24, 2017
…ts without explicit orderby, rather than using contains in the result verification This PR includes: - applying client side ordering to QueryTests (rather than doing O(n^2) result comparisons for queries without order by, - adding entry count verification (we had it in some places and not in others), - DRYing some of the commonly used asserters As a result, time to run those tests is cut down in half (40s to 20s). For now the helper methods are duplicated with the ones used in complex navs - will unify them in next checkin.
maumar
added a commit
that referenced
this issue
Jun 26, 2017
…ts without explicit orderby, rather than using contains in the result verification This PR includes: - applying client side ordering to QueryTests (rather than doing O(n^2) result comparisons for queries without order by, - adding entry count verification (we had it in some places and not in others), - DRYing some of the commonly used asserters As a result, time to run those tests is cut down in half (40s to 20s). For now the helper methods are duplicated with the ones used in complex navs - will unify them in next checkin.
maumar
added a commit
that referenced
this issue
Jun 27, 2017
…ts without explicit orderby, rather than using contains in the result verification This PR includes: - applying client side ordering to QueryTests (rather than doing O(n^2) result comparisons for queries without order by, - adding entry count verification (we had it in some places and not in others), - DRYing some of the commonly used asserters As a result, time to run those tests is cut down in half (40s to 20s). For now the helper methods are duplicated with the ones used in complex navs - will unify them in next checkin.
maumar
added a commit
that referenced
this issue
Jun 27, 2017
…ts without explicit orderby, rather than using contains in the result verification This PR includes: - applying client side ordering to QueryTests (rather than doing O(n^2) result comparisons for queries without order by, - adding entry count verification (we had it in some places and not in others), - DRYing some of the commonly used asserters As a result, time to run those tests is cut down in half (40s to 20s). For now the helper methods are duplicated with the ones used in complex navs - will unify them in next checkin.
|
fixed in f45292f |
maumar
added
the
closed-fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently QueryTest base (and some others) verify unordered results by using Contains. This is not perfect because it's slow and can cause false positives for queries where results have duplicates. Instead, we should apply logic similar to one in ComplexNavigationsQueryTest, where we apply client-side ordering and perform normal comparison afterwards
The text was updated successfully, but these errors were encountered: