Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MigrationsScaffolder is a public type registered in D.I. with no contract or dependency objects #8623

Closed
ajcvickers opened this issue May 27, 2017 · 1 comment
Closed

MigrationsScaffolder is a public type registered in D.I. with no contract or dependency objects #8623

ajcvickers opened this issue May 27, 2017 · 1 comment
Assignees
@bricelam
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
2.0.0

Comments

@ajcvickers
Copy link
Member

Typically all our public services:

  • Are defined by a contract interface
  • Use dependency object pattern so that we can add new dependencies without breaking inheritors

MigrationsScaffolder doesn't do these things. It's only added to the design-time container so maybe it doesn't matter, but it seems like it may still have the same issues as runtime services, so creating this issue to discuss.
@bricelam
Copy link
Contributor

We should do this. It should also be using IOperationReporter instead of IDiagnosticsLogger

@ajcvickers ajcvickers added this to the 2.0.0-preview2 milestone May 31, 2017
@bricelam bricelam mentioned this issue Jun 1, 2017
Merged
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 1, 2017
@ajcvickers ajcvickers modified the milestones: 2.0.0-preview2, 2.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@bricelam @ajcvickers