Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RevEng: Pass in correct argument values to ScaffoldingTypeMapper #8697

Closed
smitpatel opened this issue Jun 2, 2017 · 0 comments
Closed

RevEng: Pass in correct argument values to ScaffoldingTypeMapper #8697

smitpatel opened this issue Jun 2, 2017 · 0 comments
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone

Comments

@smitpatel
Copy link
Member

Our ScaffoldingTypeMapper takes information about column being keyOrIndex or rowversion when determining what to scaffold for store type (since keys have restricted size by default etc.)
Since there is no direct way to get that information out of ColumnModel, we are passing false flag. Which generates extra redundant Fluent API calls.

This issue is to make appropriate changes to Provider specific ScaffoldingHelper or ColumnModel which facilitate in above task and make the ScaffoldingTypeMapper more accurate.

@ajcvickers ajcvickers added this to the 2.0.0 milestone Jun 2, 2017
@bricelam bricelam modified the milestones: 2.0.0-preview2, 2.0.0 Jun 5, 2017
@bricelam bricelam assigned smitpatel and unassigned bricelam Jun 23, 2017
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Development

No branches or pull requests

3 participants