Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RevEng: Don't indent #warning #8778

Closed
bricelam opened this issue Jun 8, 2017 · 0 comments
Closed

RevEng: Don't indent #warning #8778

bricelam opened this issue Jun 8, 2017 · 0 comments
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@bricelam
Copy link
Contributor

bricelam commented Jun 8, 2017

Currently, we generate an indented #warning directive:

protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
{
    #warning To protect potentially sensitive information...
    optionsBuilder.UseSqlServer("...");
}

Formatting the generated code removes the leading whitespace. We should generate the code as it would be formatted by VS.

@smitpatel smitpatel self-assigned this Jun 8, 2017
@ajcvickers ajcvickers added this to the Backlog milestone Jun 12, 2017
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 21, 2017
@smitpatel smitpatel modified the milestones: 2.0.0, Backlog Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

No branches or pull requests

3 participants