Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate keys are not configured as AddOrUpdate/Computed #8863

Closed
ajcvickers opened this issue Jun 15, 2017 · 1 comment
Closed

Validate keys are not configured as AddOrUpdate/Computed #8863

ajcvickers opened this issue Jun 15, 2017 · 1 comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
2.0.0

Comments

@ajcvickers
Copy link
Member

Keys cannot change once the entity has been saved. This means any configuration designed to update the value after the entity has been saved is incompatible with the definition of the key. We should add a rule to model validation to check this.
@ajcvickers
Copy link
Member Author

Check also for default value.

@ajcvickers ajcvickers added this to the 2.0.0 milestone Jun 16, 2017
AndriySvyryd added a commit that referenced this issue Jun 21, 2017
@AndriySvyryd
Validate keys are not configured as AddOrUpdate/Computed
6145598 
Fixes #8863
@AndriySvyryd AndriySvyryd mentioned this issue Jun 21, 2017
Merged
AndriySvyryd added a commit that referenced this issue Jun 21, 2017
@AndriySvyryd
Validate keys are not configured as AddOrUpdate/Computed
c7b74cd 
Fixes #8863
@AndriySvyryd AndriySvyryd removed their assignment Jun 21, 2017
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@ajcvickers @AndriySvyryd