Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Databinding: Guide users to not bind against queries directly #8899

Closed
divega opened this issue Jun 19, 2017 · 0 comments
Closed

Databinding: Guide users to not bind against queries directly #8899

divega opened this issue Jun 19, 2017 · 0 comments
Assignees
@ajcvickers
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
2.0.0

Comments

@divega
Copy link
Contributor

divega commented Jun 19, 2017

Currently DbSet implements IListSource to throw an informative message pointing to DbSet.Local.ToBindingList() and DbSet.Local.ToObservableCollection but our query objects do not. Binding directly to queries can cause double roundtrips and other issues, so we should consider having the implementation of IListSource there was well as we did in EF6.
@ajcvickers ajcvickers self-assigned this Jun 21, 2017
@ajcvickers ajcvickers added this to the 2.0.0 milestone Jun 21, 2017
ajcvickers added a commit that referenced this issue Jun 28, 2017
@ajcvickers
Implement IListSource on LocalView and EntityQueryable to further dir…
f1a9378 
…ect data binding

Issues #8898 #8899
@ajcvickers ajcvickers mentioned this issue Jun 28, 2017
Merged
ajcvickers added a commit that referenced this issue Jun 28, 2017
@ajcvickers
Implement IListSource on LocalView and EntityQueryable to further dir…
6bfb10c 
…ect data binding

Issues #8898 #8899
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajcvickers ajcvickers

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@divega @ajcvickers