Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Ignore errors in design time DbContext discovery #9073

Closed
divega opened this issue Jul 5, 2017 · 4 comments
Closed

Tools: Ignore errors in design time DbContext discovery #9073

divega opened this issue Jul 5, 2017 · 4 comments
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. regression type-bug
Milestone

Comments

@divega
Copy link
Contributor

divega commented Jul 5, 2017

Any errors are thrown by creating the service container or trying to resolve DbContext from it in an ASP.NET Core apps should be ignored so that we can proceed to discover any IDesignTimeDbContextFactory<T>s.

From #9033 (comment), we believe we may have regressed.

cc @bricelam @ajcvickers

@lajones
Copy link
Contributor

lajones commented Jul 6, 2017

@divega What happens if you are trying to resolve a DbContext from an ASP.NET Core app? Could we put the errors out as debug/log messages to help debugging that scenario (but then continue on as you suggest above)?

@divega
Copy link
Contributor Author

divega commented Jul 6, 2017

I think @bricelam’s PR puts the error in the log.

@bricelam
Copy link
Contributor

bricelam commented Jul 6, 2017

Yep. Same logic as before: You'll see a warning containing the exception message, and --verbose will also give you the full stack trace and any inner exceptions.

@lajones
Copy link
Contributor

lajones commented Jul 6, 2017

@divega @bricelam Sounds great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. regression type-bug
Projects
None yet
Development

No branches or pull requests

3 participants