Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLite: Generate proper Guid literals #5848

Merged
merged 1 commit into from Jun 24, 2016
Merged

SQLite: Generate proper Guid literals #5848

merged 1 commit into from Jun 24, 2016

Conversation

bricelam
Copy link
Contributor

Fixes #5801

@ajcvickers
Copy link
Member

:shipit:

@anpete
Copy link
Contributor

anpete commented Jun 23, 2016

Anything to re-enable for #5801?

:shipit:

@ajcvickers
Copy link
Member

@anpete I didn't check in/disable anything for #5801. I found it writing tests for Find, but I just changed the tests to not use GUIDs after finding the bug. I think it would be good to have some functional tests that make use of GUID literals, but it doesn't seem essential.

@IDisposable
Copy link

:shipit:

@bricelam bricelam merged commit 091083c into dotnet:dev Jun 24, 2016
@bricelam bricelam deleted the guid branch June 24, 2016 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bricelam @ajcvickers @anpete @IDisposable @dnfclas