Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For API review: Consider renaming fluent method SeedData() to HasData() or HasSeedData() #10875

Closed
divega opened this issue Feb 5, 2018 · 0 comments
Closed

For API review: Consider renaming fluent method SeedData() to HasData() or HasSeedData() #10875

divega opened this issue Feb 5, 2018 · 0 comments
Assignees
@ajcvickers
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
2.1.0

Comments

@divega
Copy link
Contributor

divega commented Feb 5, 2018

Every time I see the method while preparing or watching the demos, the name strikes me as a bit odd.

Filing this so I don't forget. I don't remember us discussing it in API review, but perhaps I missed it.
@ajcvickers ajcvickers self-assigned this Mar 16, 2018
@ajcvickers ajcvickers added this to the 2.1.0 milestone Mar 16, 2018
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 26, 2018
@ajcvickers ajcvickers modified the milestones: 2.1.0-preview2, 2.1.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajcvickers ajcvickers

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@divega @ajcvickers