Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pipeline doesn't enforce all the identifying relationships in table splitting #10962

Closed
AndriySvyryd opened this issue Feb 14, 2018 · 1 comment
Closed

Update pipeline doesn't enforce all the identifying relationships in table splitting #10962

AndriySvyryd opened this issue Feb 14, 2018 · 1 comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
2.1.0

Comments

@AndriySvyryd
Copy link
Member

Can insert PoweredVehicle and FuelTank without CombustionEngine
@AndriySvyryd AndriySvyryd self-assigned this Feb 14, 2018
@ajcvickers ajcvickers added this to the 2.1.0 milestone Feb 16, 2018
@ajcvickers
Copy link
Member

Note that this is related to the stronger semantics of required when applied to table-splitting. That is, both the principal and dependent are always required.

AndriySvyryd added a commit that referenced this issue Feb 23, 2018
@AndriySvyryd
Fixes #10962
a5a189f
AndriySvyryd added a commit that referenced this issue Feb 23, 2018
@AndriySvyryd
Enforce the dependent requiredness for table splitting more strictly
4dd1310 
Remove discriminator column if all derived types ignored
Fix table splitting tests

Fixes #10962
Fixes #10971
AndriySvyryd added a commit that referenced this issue Feb 23, 2018
@AndriySvyryd
Enforce the dependent requiredness for table splitting more strictly
8bc8ae2 
Remove discriminator column if all derived types ignored
Fix table splitting tests

Fixes #10962
Fixes #10971
@AndriySvyryd AndriySvyryd mentioned this issue Feb 23, 2018
Merged
AndriySvyryd added a commit that referenced this issue Feb 23, 2018
@AndriySvyryd
Enforce the dependent requiredness for table splitting more strictly
3ab14a2 
Remove discriminator column if all derived types ignored
Fix table splitting tests

Fixes #10962
Fixes #10971
@AndriySvyryd AndriySvyryd removed their assignment Feb 23, 2018
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Feb 23, 2018
@ajcvickers ajcvickers modified the milestones: 2.1.0-preview2, 2.1.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@ajcvickers @AndriySvyryd