New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After upgrading to 2.1.0-rc1-final can't compile and VS 2017 crashes. #12054
Comments
@anpete Do you think this could be an analyzer issue? |
Looks like it. I was able to repro in our tests. |
- Adds visited node set to prevent re-visiting. - Also added max recursion depth fail safe in case there are more cases.
- Adds visited node set to prevent re-visiting. - Also added max recursion depth fail safe in case there are more cases.
- Adds visited node set to prevent re-visiting. - Also added max recursion depth fail safe in case there are more cases.
Removing patch-proposed until we are ready to take this to shiproom. |
This is approved by shiproom for 2.1.1 patch, but please wait for the branch to be open before merging. |
@anpete The release/2.1 branch is now open for 2.1.1 patch issues. Can we get this merged ASAP? |
- Adds visited node set to prevent re-visiting. - Also added max recursion depth fail safe in case there are more cases.
Is this already released? I've still problems with my VS see https://developercommunity.visualstudio.com/content/problem/278419/fromsql-makes-crash-visual-studio.html |
@vankooch This fix was shipped with the 2.1.1 update of EF Core. |
I had a working project running with .NET Core 2.0, EntityFrameworkCore 2.0.
I upgraded to VS 2017 15.7.1
.Net Core 2.1 (netcoreapp2.1)
EntityFrameworkCore 2.1.0-rc1-final
Now when I compile the application I get the following error:
I've narrowed the problem down to the attached class. When I open the class up in VS, VS will hang and crash.
If I comment out all of the
context.Database.ExecuteSqlCommand
lines, then it will open in VS without crashing and it will compile.I built a full project that demonstrates the issue:
MigrationHelpTest.zip
Any ideas?
Thanks,
Jason
The text was updated successfully, but these errors were encountered: