Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrading to 2.1.0-rc1-final can't compile and VS 2017 crashes. #12054

Closed
fsjason opened this issue May 17, 2018 · 7 comments
Closed

After upgrading to 2.1.0-rc1-final can't compile and VS 2017 crashes. #12054

fsjason opened this issue May 17, 2018 · 7 comments
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug
Milestone

Comments

@fsjason
Copy link

fsjason commented May 17, 2018

I had a working project running with .NET Core 2.0, EntityFrameworkCore 2.0.

I upgraded to VS 2017 15.7.1
.Net Core 2.1 (netcoreapp2.1)
EntityFrameworkCore 2.1.0-rc1-final

Now when I compile the application I get the following error:

Line	Suppression State
Error	MSB6006	"csc.exe" exited with code -1073741571.	OrgModel	
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\Bin\Roslyn\Microsoft.CSharp.Core.targets	52	

I've narrowed the problem down to the attached class. When I open the class up in VS, VS will hang and crash.

If I comment out all of the context.Database.ExecuteSqlCommand lines, then it will open in VS without crashing and it will compile.

I built a full project that demonstrates the issue:
MigrationHelpTest.zip

Any ideas?

Thanks,

Jason

@ajcvickers
Copy link
Member

@anpete Do you think this could be an analyzer issue?

@anpete
Copy link
Contributor

anpete commented May 17, 2018

Looks like it. I was able to repro in our tests.

anpete added a commit that referenced this issue May 18, 2018
- Adds visited node set to prevent re-visiting.
- Also added max recursion depth fail safe in case there are more cases.
anpete added a commit that referenced this issue May 18, 2018
- Adds visited node set to prevent re-visiting.
- Also added max recursion depth fail safe in case there are more cases.
@ajcvickers ajcvickers added this to the 2.1.1 milestone May 18, 2018
anpete added a commit that referenced this issue May 21, 2018
- Adds visited node set to prevent re-visiting.
- Also added max recursion depth fail safe in case there are more cases.
@anpete anpete closed this as completed in d44f4f9 May 22, 2018
@ajcvickers ajcvickers reopened this May 22, 2018
@ajcvickers
Copy link
Member

Removing patch-proposed until we are ready to take this to shiproom.

@ajcvickers
Copy link
Member

This is approved by shiproom for 2.1.1 patch, but please wait for the branch to be open before merging.

@ajcvickers
Copy link
Member

@anpete The release/2.1 branch is now open for 2.1.1 patch issues. Can we get this merged ASAP?

anpete added a commit that referenced this issue May 29, 2018
- Adds visited node set to prevent re-visiting.
- Also added max recursion depth fail safe in case there are more cases.
@anpete anpete added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label May 29, 2018
@anpete anpete closed this as completed May 29, 2018
@vankooch
Copy link

Is this already released? I've still problems with my VS see https://developercommunity.visualstudio.com/content/problem/278419/fromsql-makes-crash-visual-studio.html

@ajcvickers
Copy link
Member

@vankooch This fix was shipped with the 2.1.1 update of EF Core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug
Projects
None yet
Development

No branches or pull requests

4 participants